Fix handling Service Ping response with only usage_data_id
All threads resolved!
All threads resolved!
Compare changes
Files
2@@ -78,7 +78,7 @@ def save_raw_usage_data(usage_data)
Related to #337497 (closed)
https://gitlab.com/gitlab-services/version-gitlab-com/-/merge_requests/630 fixed Version App not sending usage_data_id
when there's not enough payloads from a given GitLab instance to send back full DevOps metrics in a conv_index
Hash. This only happens for a very first Service Ping from a new instance.
This turned out to not be enough to fix #337497 (closed) and ServicePing::SubmitService
now tries to save an empty DevOpsReport::Metric
record when only usage_data_id
is present in a response.
This MR fixes this behavior by omitting usage_data_id
in a check if metrics are present in a response.
These are strongly recommended to assist reviewers and reduce the time to merge your change.
gdk reset-data
ServicePing::SubmitService.base_url
to point to your local Version App instance.ServicePing::SubmitService.new.execute
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.