Leverage shared getGetDataZoomOption in Productivity Analytics
What does this MR do and why?
This MR replaces the getColumnChartDatazoomOption
getter in Productivity Analytics
with the shared getDataZoomOption
utility function that was introduced in !72004 (merged)
Screenshots or screen recordings
N/A
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #342812 (closed)
Merge request reports
Activity
changed milestone to %14.5
assigned to @wortschi
added 31 commits
-
fc35570a...309f6cd0 - 30 commits from branch
master
- b3af83ea - Leverage shared getDataZoomOption in PA
-
fc35570a...309f6cd0 - 30 commits from branch
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Coung Ngo ( @cngo
) (UTC+1, 1 hour behind@wortschi
)Jacques Erasmus ( @jerasmus
) (UTC+2, same timezone as@wortschi
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits a9dbb0ab and 4a60c926
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.24 MB 3.24 MB - -0.0 % mainChunk 1.89 MB 1.89 MB - 0.0 %
Note: We do not have exact data for a9dbb0ab. So we have used data from: c47966ab.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report for 4a60c926!review-qa-smoke:
test reportadded 237 commits
-
99b24553...105179f7 - 234 commits from branch
master
- dc9866e2 - Leverage shared getDataZoomOption in PA
- 59a029fe - Prettified app component
- baa3d3fb - Fix some linting errors
Toggle commit list-
99b24553...105179f7 - 234 commits from branch
added 405 commits
-
26e460a3...cdff3a38 - 404 commits from branch
master
- 4a60c926 - Leverage shared getDataZoomOption in PA
-
26e460a3...cdff3a38 - 404 commits from branch
requested review from @blabuschagne
- Resolved by Brandon Labuschagne
@blabuschagne Could you please review this small change (since you already have some context due to !72004 (merged))?
added typemaintenance label
added typefeature label
@blabuschagne
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
enabled an automatic merge when the pipeline for 9982512f succeeds
mentioned in commit 3a5d6113
added workflowstaging-canary label and removed workflowready for development label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
removed typefeature label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label