Re-instate missing padding for stage popovers

What does this MR do and why?

Fixes a small visual regression, this MR re-instates some CSS that was removed in !68543 (merged) to fix the alignment of the stage item popover.

This MR also fixes some minor ~"feature::maintenance" issues:

• Replaces unused js-* selectors with data-testids: #335144 (closed)

Screenshots or screen recordings

Before	After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

These checklists encourage us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Quality

• Confirmed

1. I have self-reviewed this MR per code review guidelines.
2. For the code that that this change impacts, I believe that the automated tests (Testing Guide) validate functionality that is highly important to users (including consideration of all test levels). If the existing automated tests do not cover this functionality, I have added the necessary additional tests or I have added an issue to describe the automation testing gap and linked it to this MR.
3. I have considered the technical aspects of the impact of this change on both gitlab.com hosted customers and self-hosted customers.
4. I have considered the impact of this change on the front-end, back-end, and database portions of the system where appropriate and applied frontend, backend and database labels accordingly.
5. I have tested this MR in all supported browsers, or determiend that this testing is not needed.
6. I have confirmed that this change is backwards compatible across updates, or I have decided that this does not apply.
7. I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?)
8. If I am introducing a new expectation for existing data, I have confirmed that existing data meets this expectation or I have made this expectation optional rather than required.

Performance, reliability and availability

• Confirmed

1. I am confident that this MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines)
2. I have added information for database reviewers in the MR description, or I have decided that it is unnecessary. (Does this MR have database-related changes?)
3. I have considered the availability and reliability risks of this change. I have also considered the scalability risk based on future predicted growth
4. I have considered the performance, reliability and availability impacts of this change on large customers who may have significantly more data than the average customer.

Documentation

• Confirmed

1. I have included changelog trailers, or I have decided that they are not needed. (Does this MR need a changelog?)
2. I have added/updated documentation, or I have decided that documentation changes are not needed for this MR. (Is documentation required?)

Security

• Confirmed

1. I have confirmed that if this MR contains changes to processing or storing of credentials or tokens, authorization, and authentication methods, or other items described in the security review guidelines, I have added the label security and I have @-mentioned @gitlab-com/gl-security/appsec.

Deployment

• Confirmed

1. I have considered using a feature flag for this change because the change may be high risk. If I decided to use a feature flag, I plan to test the change in staging before I test it in production, and I have considered rolling it out to a subset of production customers before doing rolling it out to all customers. When to use a feature flag
2. I have informed the Infrastructure department of a default setting or new setting change per definition of done, or decided that this is not needed.

assigned to @ekigbo

added frontend label

	1 Message
	CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog. If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message. If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Pavel Shutsin (@pshutsin) (UTC+2, 8 hours behind @ekigbo)	Heinrich Lee Yu (@engwan) (UTC+8, 2 hours behind @ekigbo)
frontend	Sheldon Led (@sheldonled) (UTC+1, 9 hours behind @ekigbo)	Jacques Erasmus (@jerasmus) (UTC+2, 8 hours behind @ekigbo)
test Quality for spec/features/*	Andrejs Cunskis (@acunskis) (UTC+3, 7 hours behind @ekigbo)	Maintainer review is optional for test Quality for spec/features/*

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 39807db0 and 3f77088e

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	3.21 MB	3.21 MB	-	0.0 %
mainChunk	1.84 MB	1.84 MB	-	0.0 %

---

Note: We do not have exact data for 39807db0. So we have used data from: ef92ff22.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.

Please look at the full report for more details

---

Read more about how this report works.

Generated by Danger

Setting label groupoptimize based on @ekigbo's group.

added groupoptimize label

Setting label(s) devopsmanage sectiondev based on groupoptimize.

added devopsfoundations sectiondev labels

added 649 commits

• 1fd205a5...3fee7c1c - 645 commits from branch master
• bc08887c - Re-instate missing padding for stage popovers
• 6fe21332 - Append json extension to group VSA paths
• 8d42b3d8 - Fix json endpoints in project vsa
• abdf42a8 - Replace unused js-* classes with test-ids

Compare with previous version

added backend label

changed milestone to %14.3

added javascript test typemaintenance labels and removed backend label

added typefeature label

changed the description

Allure report

allure-report-publisher generated test report for 3f77088e!

review-qa-smoke: test report

changed the description

added 185 commits

• abdf42a8...ef92ff22 - 183 commits from branch master
• 145e7757 - Re-instate missing padding for stage popovers
• 3f77088e - Replace unused js-* classes with test-ids

Compare with previous version

marked this merge request as ready

changed the description

added backend label

marked the checklist item Confirmed as completed

Hi @wortschi, would you have some capacity to maintainer review this MR (its not too urgent).

In !68543 (merged), I accidentally removed some additional CSS that was added to visually align the stage item popovers, this just re-instates that CSS. Additionally, I replaced the js-* selectors in #335144 (closed)

requested review from @wortschi

approved this merge request

@wortschi, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

For more info, please refer to the following links:

• rspec minimal jobs
• jest minimal jobs
• merging a merge request.

resolved all threads

enabled an automatic merge when the pipeline for cac40a94 succeeds

The failing job looks like this issue. I'll try and re-run the job in case it's flaky.

merged

mentioned in commit 00fcd482

mentioned in issue #335144 (closed)

added workflowstaging-canary label

added workflowstaging label and removed workflowstaging-canary label

added workflowcanary label and removed workflowstaging label

added workflowproduction label and removed workflowcanary label

added releasedcandidate label

added releasedpublished label and removed releasedcandidate label

removed typefeature label