Allow callsite in project for cross-database queries

Background

In #337077 (closed), we disallowed any queries that joined between tables in main: and ci: databases. e.g. (SELECT * from projects INNER JOIN ci_builds ON ci_builds.project_id = projects.id is forbidden).

There are of course existing queries that cross databases. These are allowlisted by allowing the specs that produce them, the list is in spec/support/database/cross-join-allowlist.yml.

In some cases, the spec allowlist is probably too broad so we switch to using an alternative allowlist method using allow_cross_joins_across_databases. This also allows us to annotate with the issue link where we will be fixing the cross-database query.

What does this MR do?

Allow callsite in project for cross-database queries

This callsite allow replaces at least one spec allowlist (cross-join-allowlist.yml). This callsite is called ~800 times in our CI for cross-database queries so it likely affects more than just this one spec.

Related issue: #339299 (closed), #339937 (closed)

changed milestone to %14.3

added grouptenant scale tooling (archive) labels

assigned to @tkuah

added backend label

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Drew Blessing (@dblessing) (UTC-5, 17 hours behind @tkuah)	Markus Koller (@toupeira) (UTC+2, 10 hours behind @tkuah)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

@jhyson Can you please help review ?

assigned to @jhyson and unassigned @tkuah

requested review from @jhyson

assigned to @tkuah

changed the description

approved this merge request

requested review from @nmilojevic1 and removed review request for @jhyson

unassigned @jhyson

@jhyson, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

For more info, please refer to the following links:

• rspec minimal jobs
• merging a merge request.

resolved all threads

approved this merge request

enabled an automatic merge when the pipeline for 7be7a90b succeeds

merged

mentioned in commit eab7b454

added workflowstaging label

added workflowcanary label and removed workflowstaging label

added workflowproduction label and removed workflowcanary label

mentioned in merge request !69603 (merged)

added workflowstaging-canary label and removed workflowproduction label

added releasedcandidate label

added releasedpublished label and removed releasedcandidate label

added typemaintenance label and removed tooling (archive) label

added devopsdata stores label