Convert old GraphQL types to newer type names (Part 8) [RUN AS-IF-FOSS]
What does this MR do?
During conversion to using the new graphql interpreter, I ran across this same issue: https://github.com/rmosolgo/graphql-ruby/issues/2784
So doing all the type conversions here in preparation for !27536 (merged)
- Convert
GraphQL::ID_TYPE
toGraphQL::Types::ID
- Convert
GraphQL::INT_TYPE
toGraphQL::Types::Int
- Convert
GraphQL::STRING_TYPE
toGraphQL::Types::String
- Convert
GraphQL::BOOLEAN_TYPE
toGraphQL::Types::Boolean
Screenshots or Screencasts (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #336292 (closed) and #210556 (closed)
Merge request reports
Activity
changed milestone to %14.2
assigned to @digitalmoksha
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Sashi Kumar Kumaresan ( @sashi_kumar
) (UTC+5.5, 10.5 hours ahead of@digitalmoksha
)Michael Kozono ( @mkozono
) (UTC-7, 2 hours behind@digitalmoksha
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 121 commits
-
657e0f55...7678d206 - 120 commits from branch
master
- b4fa33e6 - Convert old graphql types to newer types
-
657e0f55...7678d206 - 120 commits from branch
@pshutsin could you do the review? It's pretty simple - just changing one type string to another.
requested review from @pshutsin
requested review from @nmilojevic1 and removed review request for @pshutsin
- Resolved by Nikola Milojevic
@pshutsin, thanks for approving this merge request.Please consider starting a new pipeline if:
- This is the first time the merge request is approved, or
- The merge request is ready to be merged, and there has not been a merge request pipeline in the last 2 hours.
For more info, refer to the guideline.
added 144 commits
-
b4fa33e6...59cee0e7 - 143 commits from branch
master
- 2c6b9729 - Convert old graphql types to newer types
-
b4fa33e6...59cee0e7 - 143 commits from branch
added 42 commits
-
2c6b9729...5629c6c7 - 41 commits from branch
master
- 91936d63 - Convert old graphql types to newer types
-
2c6b9729...5629c6c7 - 41 commits from branch
marked the checklist item I have included changelog trailers, or none are needed. (Does this MR need a changelog?) as completed
marked the checklist item I have included changelog trailers, or none are needed. (Does this MR need a changelog?) as incomplete
marked the checklist item I have included changelog trailers, or none are needed. (Does this MR need a changelog?) as completed
marked the checklist item I have added/updated documentation, or it's not needed. (Is documentation required?) as completed
marked the checklist item I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) as completed
marked the checklist item I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) as completed
marked the checklist item I have self-reviewed this MR per code review guidelines. as completed
marked the checklist item I have followed the style guides. as completed
marked the checklist item This change is backwards compatible across updates, or this does not apply. as completed
marked the checklist item This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) as completed
- Resolved by Nikola Milojevic
@nmilojevic1, thanks for approving this merge request.Please consider starting a new pipeline if:
- This is the first time the merge request is approved, or
- The merge request is ready to be merged, and there has not been a merge request pipeline in the last 2 hours.
For more info, refer to the guideline.
Thanks, @digitalmoksha. LGTM
There is a merge conflict. Can you resolve it and I will set MWPS.
Edited by Nikola Milojevicadded 122 commits
-
91936d63...bd058e8c - 121 commits from branch
master
- 793bc4b8 - Convert old graphql types to newer types
-
91936d63...bd058e8c - 121 commits from branch
@nmilojevic1 thanks. I've resolved the conflict, hopefully the pipeline passes. Could you set MWPS?
enabled an automatic merge when the pipeline for b1e39041 succeeds
mentioned in commit 8937d59a
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added pipeline:run-as-if-foss label
removed typefeature label