Send source to subscriptions portal
What does this MR do?
Send source to subscriptions portal
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #334009 (closed)
Merge request reports
Activity
changed milestone to %14.1
added Deliverable devopsgrowth groupacquisition sectiongrowth labels
assigned to @a_akgun
1 Warning Please add a merge request type to this merge request. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Kassio Borges ( @kassio
) (UTC+1, 2 hours behind@a_akgun
)Jan Provaznik ( @jprovaznik
) (UTC+2, 1 hour behind@a_akgun
)frontend Fernando Arias ( @farias-gl
) (UTC-5, 8 hours behind@a_akgun
)Kushal Pandya ( @kushalpandya
) (UTC+5.5, 2.5 hours ahead of@a_akgun
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits debc2cb8 and 49237198
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.18 MB 3.18 MB - 0.0 % mainChunk 1.91 MB 1.91 MB - 0.0 %
Note: We do not have exact data for debc2cb8. So we have used data from: 073f9c44.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report for 49237198!review-qa-smoke:
test report- Resolved by Alper Akgun
added 115 commits
-
a6475c04...935e4e04 - 114 commits from branch
master
- d72a373b - Send purchase source to customers API
-
a6475c04...935e4e04 - 114 commits from branch
requested review from @jprovaznik and removed review request for @tigerwnz
- Resolved by Alper Akgun
- Resolved by Kushal Pandya
removed review request for @djadmin
- Resolved by Jan Provaznik
- Resolved by Alper Akgun
Thanks @a_akgun, LGTM
, only one question (which may not need an update).
removed review request for @jprovaznik
added 74 commits
-
d72a373b...3b143c7a - 73 commits from branch
master
- 49237198 - Send purchase source to customers API
-
d72a373b...3b143c7a - 73 commits from branch
requested review from @kushalpandya
removed review request for @kushalpandya
- Resolved by Alper Akgun
Both backend and frontend have approved. I will merge this after https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/3471, despite having little risk.
marked the checklist item I have included changelog trailers, or none are needed. (Does this MR need a changelog?) as completed
marked the checklist item I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) as completed
enabled an automatic merge when the pipeline for 6825bf4b succeeds
mentioned in commit b131b903
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label