Change FE grapqhl queries to use timeframe argument
What does this MR do?
This changes the usage of deprecated start and end date arguments in some graphql resolvers to the timeframe.
This in preparation for removing the start and end date arguments !63511 (merged). We need this merged first so that we can gracefully handle rolling-deploys.
For more context:
re #332888 (closed) re #267966 (closed) re !63293 (merged)
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
assigned to @acroitor
- A deleted user
added frontend label
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Robert Hunt ( @rob.hunt
) (UTC+1, 2 hours behind@acroitor
)Nathan Friend ( @nfriend
) (UTC-4, 7 hours behind@acroitor
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerchanged milestone to %14.0
added 1 commit
- 645947ae - Change FE grapqhl queries to use timeframe argument
mentioned in merge request !63468 (closed)
added 18 commits
-
645947ae...d159b28f - 17 commits from branch
handle_timeframe_arguments
- 9913967f - Change FE grapqhl queries to use timeframe argument
-
645947ae...d159b28f - 17 commits from branch
Allure report
allure-report-publisher
generated test report for bcc75a46!review-qa-smoke:
test reportmentioned in merge request !63293 (merged)
added 519 commits
-
9913967f...85e509c2 - 518 commits from branch
master
- 5f37a0d9 - Change FE grapqhl queries to use timeframe argument
-
9913967f...85e509c2 - 518 commits from branch
- Resolved by Kushal Pandya
@euko mind taking a look at this change?
requested review from @euko
removed backend label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits b383cb65 and bcc75a46
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.18 MB 3.18 MB - -0.0 % mainChunk 1.91 MB 1.91 MB - 0.0 %
Note: We do not have exact data for b383cb65. So we have used data from: e84cf8ce.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded workflowin review label and removed workflowin dev label
- Resolved by Alexandru Croitor
- Resolved by Alexandru Croitor
removed review request for @euko
added 1 commit
- bcc75a46 - Change FE grapqhl queries to use timeframe argument
requested review from @kushalpandya
mentioned in commit 68746a8e
added workflowstaging label and removed workflowin review label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added typemaintenance label