Skip to content

Drop remove_on_close column from labels table in envs where it exists

Mario Celi requested to merge 331414-drop-labels-remove-on-close-column into master

What does this MR do?

Removes remove_on_close column from the labels table on envs where the original migration (from !61286 (merged)) was run. Migration was reverted before a new release was made.

Step 2 of 3 on column removal. Column was already ignored in a previous release (!62246 (merged))

Relates to #331414 (closed)

Migration output

UP when column exists

== 20210531164210 DropRemoveOnCloseFromLabels: migrating ======================
-- column_exists?(:labels, :remove_on_close)
   -> 0.0031s
-- remove_column(:labels, :remove_on_close)
   -> 0.0013s
== 20210531164210 DropRemoveOnCloseFromLabels: migrated (0.0103s) =============

UP when column does not exist

== 20210531164210 DropRemoveOnCloseFromLabels: migrating ======================
-- column_exists?(:labels, :remove_on_close)
   -> 0.0031s
== 20210531164210 DropRemoveOnCloseFromLabels: migrated (0.0032s) =============

DOWN

== 20210531164210 DropRemoveOnCloseFromLabels: reverting ======================
== 20210531164210 DropRemoveOnCloseFromLabels: reverted (0.0000s) =============

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #331414 (closed)

Edited by Mario Celi

Merge request reports