Optimize query for reference parser [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
It applies optimizations to MergeRequestParser for PostProcess pipeline.
Problem
We want to verify that links to merge requests are available for the current user. If they are not available, then we hide them.
Currently, we load all merge requests for each reference present on the page and check if the current user has access to their projects.
New approach
On the previous step, MergeRequestReferenceFilter converts references like !123 to HTML links. It additionally populates data attributes with meta information. The most important for us are merge request id and project id.
Instead of loading all merge request objects, we can fetch only their projects by ids defined in data attributes and verify if the user has access to them.
That significantly improves the performance.
Screenshots (strongly suggested)
| Before | After |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team