Remove the FF ci_needs_optional [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
This MR removes the FF ci_needs_optional
.
- Feature issue: #30680 (closed)
- Introduced in: !55468 (merged)
- Rollout issue: #323891 (closed)
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %14.0
added backend devopsverify feature flag grouppipeline authoring sectionops typefeature typemaintenance workflowin review + 1 deleted label
marked the checklist item I have added/updated documentation, or it's not needed. (Is documentation required?) as completed
marked the checklist item I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) as completed
marked the checklist item I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) as completed
marked the checklist item I have self-reviewed this MR per code review guidelines. as completed
marked the checklist item This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) as completed
marked the checklist item I have followed the style guides. as completed
marked the checklist item I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) as completed
marked the checklist item I have tested this MR in all supported browsers, or it's not needed. as completed
marked the checklist item I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed. as completed
added documentation label
2 Messages 📖 This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. 📖 You're adding or removing a feature flag, your MR title needs to include [RUN ALL RSPEC] [RUN AS-IF-FOSS]
(we may have updated it automatically for you and started a new MR pipeline) to ensure everything is covered.Documentation review
The following files require a review from a technical writer:
doc/ci/yaml/README.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Mehmet Emin Inac ( @minac
) (UTC+3, same timezone as@furkanayhan
)Kerri Miller ( @kerrizor
) (UTC-7, 10 hours behind@furkanayhan
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖removed workflowin review label
marked the checklist item I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) as completed
requested review from @eurie
- Resolved by Furkan Ayhan
@marcel.amirault Can you please review the documentation changes?
requested review from @marcel.amirault
added 108 commits
added Technical Writing docsfeature labels
removed review request for @marcel.amirault
added twfinished label
- Resolved by Mark Chao
@furkanayhan I think we need a changelog (see https://gitlab.com/gitlab-org/gitlab/-/blob/master/doc/development/feature_flags/index.md#changelog). Otherwise this looks good!
assigned to @lulalala
added 80 commits
-
6e88ffb9...bfe2457a - 79 commits from branch
master
- d0c8120a - Remove the FF ci_needs_optional
-
6e88ffb9...bfe2457a - 79 commits from branch
enabled an automatic merge when the pipeline for 43b76573 succeeds
mentioned in commit 34126e4f
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!39 (merged)
added releasedpublished label and removed releasedcandidate label
removed typefeature label
added pipeline:run-all-rspec pipeline:run-as-if-foss labels
added Category:Pipeline Composition label