Skip to content
Snippets Groups Projects

Move 5 integrations to Integrations:: namespace [RUN ALL RSPEC]

Merged Luke Duncalfe requested to merge 201855-rename-project_services_to_integrations-5 into master
All threads resolved!

What does this MR do?

This MR moves five more integrations to the Integrations:: namespace as part of #201855 (closed).

It builds on the groundwork in !60968 (merged) to safely rename STI models.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Related to #201855 (closed)

Edited by Douglas Barbosa Alexandre

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
2 2
3 3 # This class is to be removed with 9.1
4 4 # We should also by then remove BuildsEmailService from database
5 class BuildsEmailService < Integration
6 def self.to_param
7 'builds_email'
8 end
5 # # https://gitlab.com/gitlab-org/gitlab/-/issues/331064
  • Luke Duncalfe added 1 commit

    added 1 commit

    • 6ffa3a16 - Move 5 integrations to Integrations:: namespace

    Compare with previous version

  • Author Maintainer

    Hi, @alexkalderimis! Could you please give this MR its first backend review? Thank you!

  • added workflowin review label and removed workflowin dev label

  • requested review from @alexkalderimis

  • Luke Duncalfe
  • Luke Duncalfe added 1 commit

    added 1 commit

    • 51a8e8ed - Move 5 integrations to Integrations:: namespace

    Compare with previous version

  • Alex Kalderimis approved this merge request

    approved this merge request

  • Looks great to me!

  • Alex Kalderimis removed review request for @alexkalderimis

    removed review request for @alexkalderimis

  • @dbalexandre - could you please give this MR its backend maintainer review?

  • requested review from @dbalexandre

  • resolved all threads

  • Douglas Barbosa Alexandre changed title from Move 5 integrations to Integrations:: namespace to Move 5 integrations to Integrations:: namespace [RUN ALL RSPEC]

    changed title from Move 5 integrations to Integrations:: namespace to Move 5 integrations to Integrations:: namespace [RUN ALL RSPEC]

  • Douglas Barbosa Alexandre approved this merge request

    approved this merge request

  • Douglas Barbosa Alexandre enabled an automatic merge when the pipeline for 6c887326 succeeds

    enabled an automatic merge when the pipeline for 6c887326 succeeds

  • Thanks, @.luke! This LGTM :thumbsup:

  • Douglas Barbosa Alexandre aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • added 199 commits

    Compare with previous version

  • Douglas Barbosa Alexandre enabled an automatic merge when the pipeline for 0f8ee931 succeeds

    enabled an automatic merge when the pipeline for 0f8ee931 succeeds

  • mentioned in commit 2612a344

  • added workflowstaging label and removed workflowin review label

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • 🤖 GitLab Bot 🤖 added 1 deleted label and removed devopscreate label

    added 1 deleted label and removed devopscreate label

  • 🤖 GitLab Bot 🤖 added devopsfoundations label and removed 1 deleted label

    added devopsfoundations label and removed 1 deleted label

  • Please register or sign in to reply
    Loading