Move 5 integrations to Integrations:: namespace [RUN ALL RSPEC]
What does this MR do?
This MR moves five more integrations to the Integrations::
namespace as part of #201855 (closed).
It builds on the groundwork in !60968 (merged) to safely rename STI models.
Does this MR meet the acceptance criteria?
Conformity
- [-] I have included a changelog entry, or it's not needed. (Does this MR need a changelog?)
- [-] I have added/updated documentation, or it's not needed. (Is documentation required?)
- [-] I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?)
- [-] I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
-
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) - [-] I have tested this MR in all supported browsers, or it's not needed.
- [-] I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Related to #201855 (closed)
Merge request reports
Activity
changed milestone to %13.12
added 1 commit
- 0a86c92b - Move 5 integrations to Integrations:: namespace
1 Warning This merge request is quite big (940 lines changed), please consider splitting it into multiple merge requests. 2 Messages CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 61854 "Move 5 integrations to Integrations:: namespace [RUN ALL RSPEC]"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 61854 "Move 5 integrations to Integrations:: namespace [RUN ALL RSPEC]"
If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
We are in the process of rolling out a new workflow for adding changelog entries. This new workflow uses Git commit subjects and Git trailers to generate changelogs. This new approach will soon replace the current YAML based approach. To ease the transition process, we recommend you start using both the old and new approach in parallel. This is not required at this time, but will make it easier to transition to the new approach in the future. To do so, pick the commit that should go in the changelog and add a
Changelog
trailer to it. For example:This is my commit's subject line This is the optional commit body. Changelog: added
The value of the
Changelog
trailer should be one of the following: added, fixed, changed, deprecated, removed, security, performance, other.For more information, take a look at the following resources:
https://gitlab.com/gitlab-com/gl-infra/delivery/-/issues/1564
- https://docs.gitlab.com/ee/api/repositories.html#generate-changelog-data
If you'd like to see the new approach in action, take a look at the commits in the Omnibus repository.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Lucas Charles ( @theoretick
) (UTC-7, 19 hours behind@.luke
)Heinrich Lee Yu ( @engwan
) (UTC+8, 4 hours behind@.luke
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖2 2 3 3 # This class is to be removed with 9.1 4 4 # We should also by then remove BuildsEmailService from database 5 class BuildsEmailService < Integration 6 def self.to_param 7 'builds_email' 8 end 5 # # https://gitlab.com/gitlab-org/gitlab/-/issues/331064 changed this line in version 3 of the diff
added 1 commit
- 6ffa3a16 - Move 5 integrations to Integrations:: namespace
Hi, @alexkalderimis! Could you please give this MR its first backend review? Thank you!
added workflowin review label and removed workflowin dev label
requested review from @alexkalderimis
- Resolved by Douglas Barbosa Alexandre
added 1 commit
- 51a8e8ed - Move 5 integrations to Integrations:: namespace
removed review request for @alexkalderimis
@dbalexandre - could you please give this MR its backend maintainer review?
requested review from @dbalexandre
enabled an automatic merge when the pipeline for 6c887326 succeeds
Thanks, @.luke! This LGTM
added 199 commits
-
51a8e8ed...43a97e56 - 198 commits from branch
master
- c1867b98 - Move 5 integrations to Integrations:: namespace
-
51a8e8ed...43a97e56 - 198 commits from branch
enabled an automatic merge when the pipeline for 0f8ee931 succeeds
mentioned in commit 2612a344
added workflowstaging label and removed workflowin review label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added 1 deleted label and removed devopscreate label
removed typefeature label
added devopsfoundations label and removed 1 deleted label