Remove feature flag for LFS integrity check via quarantined objects [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
The change to use the quarantine environment for LFS integrity checks has been enabled in production now for some time with the expected benefits: if used, the new check is up to several magnitudes faster than the old LFS pointer check.
Let's drop the feature flag and make this new feature generally available.
Rollout issue: #327440 (closed) Part of gitaly#3537 (closed)
Screenshots (strongly suggested)
Performance of old implementation versus the new one:
Same graph, but only for gitlab-org/gitlab:
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Patrick Steinhardt