Resolve "Master broken: in spec/requests/api/conan_project_packages_spec.rb"
What does this MR do?
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #326194
Merge request reports
Activity
added master:broken label
@rymai - could you please review?
assigned to @rymai
added backend label
2 Warnings Please add a merge request type to this merge request. This merge request does not refer to an existing milestone. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 57695 "Resolve "Master broken: in spec/requests/api/conan_project_packages_spec.rb""
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 57695 "Resolve "Master broken: in spec/requests/api/conan_project_packages_spec.rb""
If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Nicolas Dular ( @nicolasdular
) (UTC+2, 1 hour ahead of@alexkalderimis
)Dylan Griffith ( @DylanGriffith
) (UTC+11, 10 hours ahead of@alexkalderimis
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded typemaintenance label
added typefeature label
enabled an automatic merge when the pipeline for 7a00eb32 succeeds
mentioned in commit 63a18c1c
mentioned in issue gitlab-com/gl-infra/scalability#958
changed milestone to %13.11
Thanks @alexkalderimis and @smcgivern!
unassigned @rymai
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added groupecosystem [DEPRECATED] label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
removed typefeature label
added devopsmanage label and removed 1 deleted label