BE: Allow customers to extend or reactivate their trial on gitlab.com [RUN ALL RSPEC] [RUN AS-IF-FOSS]

What does this MR do?

Related to issue #290278 (closed)

There are 4 MRs for issue #290278 (closed)

• migration script on Gitlab: !56460 (merged)
• migration script on CustomersDot: https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/2937
• feature code on Gitlab: !56471 (merged) (this MR)
• feature code on CustomersDot: https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/2940

Note: the issue's Data requirement has not confirmed yet, so please ignore data requirement during review.

This MR add a put method extend_reactivate in trials controller

• it requires params[:trial_extension_type] as one params
• it validates params[:trial_extension_type] against the namespace
• if the request is valid, it calls GitlabSubscriptions::ExtendReactivateTrialService
• GitlabSubscriptions::ExtendReactivateTrialService will send a put request to CustomersDot

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

• 📋 Does this MR need a changelog?
  • I have included a changelog entry.
  • I have not included a changelog entry because _____.
• Documentation (if required)
• Code review guidelines
• Merge request performance guidelines
• Style guides
• Database guides
• Separation of EE specific content

Availability and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• Tested in all supported browsers
• Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• Label as security and @ mention @gitlab-com/gl-security/appsec
• The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• Security reports checked/validated by a reviewer from the AppSec team

Related to #290278 (closed)

ee/app/controllers/trials_controller.rb

@@ -9,7 +9,7 @@ class TrialsController < ApplicationController
   before_action :authenticate_user!
   before_action :find_or_create_namespace, only: :apply
   before_action :find_namespace, only: [:extend_reactivate]
-  before_action :authenticate_owner!, only: [:extend_reactivate]
+  before_action :authenticate_namespace_owner!, only: [:extend_reactivate]
 
   feature_category :purchase
 
@@ -52,17 +52,7 @@ def apply
   end
 
   def extend_reactivate
-    trial_extension_type = params[:trial_extension_type].to_i
-
-    return render_403 unless [GitlabSubscription::TRIAL_EXTENDED, GitlabSubscription::TRIAL_REACTIVATED].include?(trial_extension_type)
-
-    return render_403 if trial_extension_type == GitlabSubscription::TRIAL_EXTENDED && !@namespace.can_extend?
-
-    return render_403 if trial_extension_type == GitlabSubscription::TRIAL_REACTIVATED && !@namespace.can_reactivate?
-
-    return render_403 if @namespace.invalid?
-
-    @result = GitlabSubscriptions::ExtendReactivateTrialService.new.execute(extend_reactivate_trial_params)
+    @result = GitlabSubscriptions::ExtendReactivateTrialService.new.execute(extend_reactivate_trial_params) if valid_extension?
 
     if @result&.dig(:success)
       head 200
@@ -86,7 +76,7 @@ def authenticate_user!
     redirect_to new_trial_registration_path, alert: I18n.t('devise.failure.unauthenticated')
   end
 
-  def authenticate_owner!
+  def authenticate_namespace_owner!
     render_403 unless @namespace.owners.include?(current_user)
   end
 
@@ -147,6 +137,18 @@ def find_namespace?
     params[:namespace_id].present? && params[:namespace_id] != '0'
   end
 
+  def valid_extension?
+    trial_extension_type = params[:trial_extension_type].to_i
+
+    return false unless [GitlabSubscription::TRIAL_EXTENDED, GitlabSubscription::TRIAL_REACTIVATED].include?(trial_extension_type)
+
+    return false if trial_extension_type == GitlabSubscription::TRIAL_EXTENDED && !@namespace.can_extend?
+
+    return false if trial_extension_type == GitlabSubscription::TRIAL_REACTIVATED && !@namespace.can_reactivate?
+
+    true
+  end
+
   def can_create_group?
     params[:new_group_name].present? && can?(current_user, :create_group)
   end