File templates fetching refactor [RUN AS-IF-FOSS] [RUN ALL RSPEC]

What does this MR do?

This MR tries to extract a part of the bigger !51692 (closed) MR related to common code around file template fetching.

Refactor the code around template fetching to make it reusable and ready to be adjusted for inheritable issue and merge requests templates.

The intent is of this MR is to also use TemplateFinder as SSOT for fetching templates. We have several types of file templates, but only issue and merge request description template names are cached. That has been added some time ago now, but I think it is done mostly because of the higher usage of issues and merge requests where caching helps limit the number of requests to gitaly. Because issue and merge requests use caching we were fetching those template names through repository model and other template names by calling the TemplateFinder.build().execute.

With this change we can fetch all templates through TemplateFinder.template_names(project, type) and it will take care to fetch the issue and merge request ones from cache.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

• Changelog entry
• Documentation (if required)
• Code review guidelines
• Merge request performance guidelines
• Style guides
• Database guides
• Separation of EE specific content

Availability and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• Tested in all supported browsers
• Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• Label as security and @ mention @gitlab-com/gl-security/appsec
• The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• Security reports checked/validated by a reviewer from the AppSec team

spec/helpers/issuables_description_templates_helper_spec.rb

+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe IssuablesDescriptionTemplatesHelper do
+  include_context 'project issuable templates context'
+
+  describe '#issuable_templates' do
+    let_it_be(:inherited_from) { nil }
+    let_it_be(:user) { create(:user) }
+    let_it_be(:parent_group) { create(:group) }
+    let_it_be(:project) { create(:project, :custom_repo, files: issuable_template_files) }
+    let_it_be(:group_member) { create(:group_member, :developer, group: parent_group, user: user) }
+    let_it_be(:project_member) { create(:project_member, :developer, user: user, project: project) }
+
+    it 'returns empty array when template type does not exist' do
+      expect(TemplateFinder).not_to receive(:template_names).and_call_original
+      expect(helper.issuable_templates(build(:project), 'non-existent-template-type')).to eq([])
+    end
+
+    context 'with memoized templates' do
+      let(:project) { build(:project) }
+
+      before do
+        helper.issuable_templates(project, 'issues')
+        helper.issuable_templates(project, 'non-existent')
+      end
+
+      it 'does not call TemplateFinder' do
+        expect(TemplateFinder).not_to receive(:template_names)
+
+        helper.issuable_templates(project, 'issues')
+        helper.issuable_templates(project, 'non-existent')
+      end
+    end
+
+    context 'when project has no parent group' do
+      it_behaves_like 'project issuable templates'
+    end
+
+    context 'when project has parent group' do
+      before do
+        project.update!(group: parent_group)
+      end
+
+      context 'when project parent group does not have a file template project' do
+        it_behaves_like 'project issuable templates'
+      end
+
+      context 'when project parent group has a file template project' do
+        let_it_be(:file_template_project) { create(:project, :custom_repo, group: parent_group, files: issuable_template_files) }
+        let_it_be(:group) { create(:group, parent: parent_group) }
+        let_it_be(:project) { create(:project, :custom_repo, group: group, files: issuable_template_files) }
+
+        before do
+          project.update!(group: group)
+          parent_group.update_columns(file_template_project_id: file_template_project.id)
+
+          parent_group.reload
+          project.reload
+        end
+
+        it_behaves_like 'project issuable templates'
+      end
+    end
+  end
+
+  describe '#issuable_templates_names' do
+    let(:project) { double(Project, id: 21) }
+
+    let(:templates) do
+      [
+        { name: "another_issue_template", id: "another_issue_template", project_id: project.id },
+        { name: "custom_issue_template", id: "custom_issue_template", project_id: project.id }
+      ]
+    end
+
+    it 'returns project templates only' do
+      allow(helper).to receive(:ref_project).and_return(project)
+      allow(helper).to receive(:issuable_templates).and_return(templates)
+
+      expect(helper.issuable_templates_names(Issue.new)).to eq(%w[another_issue_template custom_issue_template])
+    end
+
+    context 'templates as empty hash' do
+      let(:templates) { {} }
+
+      it 'returns empty array' do
+        allow(helper).to receive(:ref_project).and_return(project)
+        allow(helper).to receive(:issuable_templates).and_return(templates)
+
+        expect(helper.issuable_templates_names(Issue.new)).to eq([])
+      end
+    end
+  end
+end