Skip to content

Remove redundant let in reviewers spec

Samantha Ming requested to merge 296998-refactor-reviewer-spec into master

What does this MR do?

Issue: #296998 (closed)

Remove the duplicate let instance variables in testing the reviewer_approval_rules being on and off. So it looks something like this:

Before Fix
image image

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #296998 (closed)

Edited by Samantha Ming

Merge request reports