Fix requirements import authorize route to match Workhorse route
What does this MR do?
Related to #246857 (closed)
In !48060 (merged) the new endpoint import_csv
was introduced to import Requirements. This endpoint requires Workhorse authorization and the new WH route was added here: gitlab-workhorse!664 (merged).
When implementing the UI changes we noticed that the Rails route didn't match resulting in the following error:
Started POST “/gitlab-org/gitlab-test/-/requirements_management/requirements/import_csv/authorize” for 127.0.0.1 at 2020-12-08 17:20:53 +0000
No route matches [POST] “/gitlab-org/gitlab-test/-/requirements_management/requirements/import_csv/authorize” excluded from capture: DSN not set
This MR fixes the rails route and allows the requirements to be successfully imported from a CSV file.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #284138 (closed)
Merge request reports
Activity
changed milestone to %13.7
removed workflowverification label
1 Message 📖 CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 49594 "Fix requirements import authorize route to match Workhorse route"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 49594 "Fix requirements import authorize route to match Workhorse route"
If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Albert Salim ( @caalberts
) (UTC+8, 8 hours ahead of@egrieff
)Heinrich Lee Yu ( @engwan
) (UTC+8, 8 hours ahead of@egrieff
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖added typemaintenance label and removed featureaddition label
- Resolved by Heinrich Lee Yu
- Resolved by Heinrich Lee Yu
@caalberts
👋 would you mind taking the first review, please?🙇 (Changelog missing because this feature is still behind a feature flag)
assigned to @caalberts
assigned to @engwan and unassigned @caalberts and @egrieff
assigned to @egrieff
Thanks @egrieff, looks good to me
👍 enabled an automatic merge when the pipeline for 93fe30d8 succeeds
mentioned in commit 5559a68e
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
removed typefeature label