Skip to content
Snippets Groups Projects

Fix requirements import authorize route to match Workhorse route

All threads resolved!

What does this MR do?

Related to #246857 (closed)

In !48060 (merged) the new endpoint import_csv was introduced to import Requirements. This endpoint requires Workhorse authorization and the new WH route was added here: gitlab-workhorse!664 (merged).

When implementing the UI changes we noticed that the Rails route didn't match resulting in the following error:

Started POST /gitlab-org/gitlab-test/-/requirements_management/requirements/import_csv/authorize for 127.0.0.1 at 2020-12-08 17:20:53 +0000
No route matches [POST] /gitlab-org/gitlab-test/-/requirements_management/requirements/import_csv/authorize excluded from capture: DSN not set

This MR fixes the rails route and allows the requirements to be successfully imported from a CSV file.

Screenshots (strongly suggested)

Screen_Shot_2020-12-09_at_15.45.58

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #284138 (closed)

Edited by Eugenia Grieff

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Eugenia Grieff changed the description

    changed the description

  • Albert Salim assigned to @engwan and unassigned @caalberts and @egrieff

    assigned to @engwan and unassigned @caalberts and @egrieff

  • assigned to @egrieff

  • Heinrich Lee Yu approved this merge request

    approved this merge request

  • Heinrich Lee Yu resolved all threads

    resolved all threads

  • Thanks @egrieff, looks good to me 👍

  • Heinrich Lee Yu enabled an automatic merge when the pipeline for 93fe30d8 succeeds

    enabled an automatic merge when the pipeline for 93fe30d8 succeeds

  • Heinrich Lee Yu mentioned in commit 5559a68e

    mentioned in commit 5559a68e

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • Please register or sign in to reply
    Loading