Update icons to svg in several sort dropdowns
What does this MR do?
Update icons to svg in several sort dropdowns Alexander Turinske authored 1 minute ago
- milestone
- label
- wiki
- search
- todos
Screenshots (strongly suggested)
Location | Before | After |
---|---|---|
Create wiki page | ![]() |
![]() |
Search issues sort | ![]() |
![]() |
Search GitLab sort | ![]() |
![]() |
Todos sort | ![]() |
![]() |
Milestone sort | ![]() |
![]() |
Label sort | ![]() |
![]() |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #224509 (closed)
Merge request reports
Activity
changed milestone to %Backlog
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the tooling, ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend André Luís ( @andr3
) (UTC+0, 7 hours ahead of@aturinske
)Paul Slaughter ( @pslaughter
) (UTC-6, 1 hour ahead of@aturinske
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 1 commit
- e90ad4bb - Update icons to svg in several sort dropdowns
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits c9a8a2f0 and e90ad4bb
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.16 MB 3.16 MB - 0.0 % mainChunk 1.95 MB 1.95 MB - 0.0 %
Note: We do not have exact data for c9a8a2f0. So we have used data from: a4bbb806.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by 🤖 GitLab Bot 🤖removed [deprecated] Accepting merge requests label
Setting label(s) Category:Vulnerability Management based on groupthreat insights.
added Category:Vulnerability Management label
- Resolved by Paul Slaughter
@cngo could you give this a review? Thanks
assigned to @cngo
assigned to @pslaughter and unassigned @cngo
assigned to @ekigbo and unassigned @pslaughter
mentioned in merge request !48171 (merged)
assigned to @pslaughter and unassigned @ekigbo
- Resolved by Paul Slaughter
mentioned in issue #285229
enabled an automatic merge when the pipeline for 8bf439ac succeeds
mentioned in commit 2a39ef32
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
removed typefeature label