Skip to content
Snippets Groups Projects

Update icons to svg in several sort dropdowns

Merged Alexander Turinske requested to merge 224509-chevron-down-svg-search-wiki into master
All threads resolved!

What does this MR do?

Update icons to svg in several sort dropdowns Alexander Turinske authored 1 minute ago

  • milestone
  • label
  • wiki
  • search
  • todos

Screenshots (strongly suggested)

Location Before After
Create wiki page wiki-old wiki-new
Search issues sort search_issue_sort-old search_issue_sort-new
Search GitLab sort search_sort-old search_sort-new
Todos sort todo-old todo-new
Milestone sort milestone_sort-old milestone_sort-new
Label sort label_sort-old label_sort-new

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #224509 (closed)

Edited by Alexander Turinske

Merge request reports

Merged results pipeline #218766193 passed

Merged results pipeline passed for 8bf439ac

Test coverage 69.89% (-1.14%) from 3 jobs

Merged by Paul SlaughterPaul Slaughter 4 years ago (Nov 23, 2020 6:10pm UTC)

Loading

Pipeline #220155403 passed

Pipeline passed for 2a39ef32 on master

Test coverage 57.34% (-1.14%) from 3 jobs
5 environments impacted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Paul Slaughter mentioned in issue #285229

    mentioned in issue #285229

  • Paul Slaughter resolved all threads

    resolved all threads

  • Paul Slaughter resolved all threads

    resolved all threads

  • LGTM! Thanks for this MR @aturinske! :tada:

    lgtm

    Approving and MWPS'ing...

  • Paul Slaughter approved this merge request

    approved this merge request

  • Paul Slaughter enabled an automatic merge when the pipeline for 8bf439ac succeeds

    enabled an automatic merge when the pipeline for 8bf439ac succeeds

  • Paul Slaughter resolved all threads

    resolved all threads

  • Paul Slaughter mentioned in commit 2a39ef32

    mentioned in commit 2a39ef32

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • Please register or sign in to reply
    Loading