Fix broken assigee title component prop
What does this MR do?
A tiny MVC to fix the broken board sidebar assignee title prop error by allowing the prop to default to false when not passed as a prop.
Screenshots (strongly suggested)
Before | After |
---|---|
![]() |
![]() |
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
- [-] Code review guidelines
- [-] Merge request performance guidelines
- [-] Style guides
- [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %13.6
assigned to @nmezzopera
As this is a two line change would you mind have a look for me?
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the tooling, ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 47397 "Fix broken assigee title component prop"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 47397 "Fix broken assigee title component prop"
If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Coung Ngo ( @cngo
) (UTC+0, same timezone as@oregand
)Kushal Pandya ( @kushalpandya
) (UTC+5.5, 5.5 hours ahead of@oregand
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded maintenancerefactor typemaintenance labels
added typefeature label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits a2dfdbba and bae05920
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.11 MB 3.11 MB - 0.0 % mainChunk 1.88 MB 1.88 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
Dangermentioned in commit 10f1f4ad
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
removed typefeature label
added Category:Team Planning label