DevOps Adoption: Integrate table component
What does this MR do?
This MR adds the segment table API integration to the devops adoption tab of the devops report feature. The empty state and table have already been merged in separate MRs.
In order to test you'll need;
- Admin access
- An instance wide Ultimate license
- The
devops_adoption_feature
flag enabled
Backend MR: !47388 (merged)
Feature flag rollout issue: #271568 (closed)
Screenshots (strongly suggested)
No data | Data | Error |
---|---|---|
![]() |
![]() |
![]() |
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines - [-] Merge request performance guidelines
-
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Related to #271249 (closed)
Merge request reports
Activity
changed milestone to %13.6
assigned to @blabuschagne
removed workflowready for development label
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on throughput implementation.
- The definition of done documentation.
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 47164 "DevOps Adoption: Integrate table component"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 47164 "DevOps Adoption: Integrate table component"
If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Dave Pisek ( @dpisek
) (UTC+11, 9 hours ahead of@blabuschagne
)Miguel Rincon ( @mrincon
) (UTC+1, 1 hour behind@blabuschagne
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 1848e5e4 and 3f3c5ed1
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.03 MB 3.03 MB - 0.0 % mainChunk 1.88 MB 1.88 MB - 0.0 % Significant Growth: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.admin.dev_ops_report 826.27 KB 971.77 KB +145.5 KB 17.6 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@dmishunov
,@justin_ho
,@mikegreiling
or@nmezzopera
) for review, if you are unsure about the size increase.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by 🤖 GitLab Bot 🤖mentioned in merge request !47376 (merged)
added 497 commits
-
9b3e6e9f...f0e075d2 - 496 commits from branch
master
- 23b12003 - Add devops adoption table
-
9b3e6e9f...f0e075d2 - 496 commits from branch
@mlunoe as discussed via Zoom, I've updated this MR to now include the new segment button as well as the last updated text in the main app file - as simplifies swapping out the button for the modal component which you are working on.
mentioned in merge request !47491 (merged)
mentioned in merge request !47623 (merged)
added 890 commits
-
323661e9...1d54afb2 - 889 commits from branch
master
- ee52463c - Add devops adoption table
-
323661e9...1d54afb2 - 889 commits from branch
changed milestone to %13.7
added 359 commits
-
c6bee5c4...695735e3 - 358 commits from branch
master
- c1bfea18 - Add devops adoption table
-
c6bee5c4...695735e3 - 358 commits from branch
added 203 commits
-
c1bfea18...cef708c2 - 202 commits from branch
master
- 677e1c1f - Add devops adoption table
-
c1bfea18...cef708c2 - 202 commits from branch
added 144 commits
-
d9d71d35...e1dff736 - 143 commits from branch
master
- 4c4e0234 - Add devops adoption table
-
d9d71d35...e1dff736 - 143 commits from branch
- Resolved by Brandon Labuschagne
@tomquirk can you please initial review this?
assigned to @tomquirk
added 7 commits
-
4c4e0234...38f7c0a8 - 6 commits from branch
master
- 9e0c89dc - Add devops adoption table
-
4c4e0234...38f7c0a8 - 6 commits from branch
- Resolved by Brandon Labuschagne
- Resolved by Tom Quirk
- Resolved by Brandon Labuschagne
- Resolved by Tom Quirk
- Resolved by Tom Quirk
- Resolved by Tom Quirk
- Resolved by Brandon Labuschagne
- Resolved by Tom Quirk
unassigned @tomquirk