Permissions for Security bot
Note
This MR is not for master, we need these permissions for !44618 (closed)
What does this MR do?
Discovery issue: #36500 (closed) Backend issue: #215669 (closed)
Adds permissions needed to the bot to create an MR
Permissions added
- Security bot has developer access to projects where auto fix is enabled
Security blocks
[3] pry(main)> GlobalPolicy.new(User.security_bot, :global).can?(:log_in)
=> false
pry(main)> GlobalPolicy.new(User.security_bot, :global).can?(:access_api)
User Load (0.6ms) SELECT "users".* FROM "users" WHERE "users"."user_type" = $1 ORDER BY "users"."id" ASC LIMIT $2 [["user_type", 8], ["LIMIT", 1]]
=> false
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #215669 (closed)