Run project housekeeping for pull mirrors
What does this MR do?
Treats each git fetch
into a pull mirror as-if it's a git push
into the repository, and enqueues project housekeeping tasks on the same schedule.
This should reduce the storage cost of pull mirrors, which are a small, but noticeable, proportion of the total on GitLab.com
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #214092 (closed)
Merge request reports
Activity
changed milestone to %Backlog
marked the checklist item Changelog entry as completed
changed milestone to %13.6
added backend label
- Resolved by Igor Drozdov
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Josianne Hyson ( @jhyson
) (UTC+1, 1 hour ahead of@nick.thomas
)Heinrich Lee Yu ( @engwan
) (UTC+8, 8 hours ahead of@nick.thomas
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖
- Resolved by Nick Thomas
removed [deprecated] Accepting merge requests label
@avielle do you mind giving this a first review? The idea is to make pull mirrors take up less space on disk :)
assigned to @avielle
Setting label(s) Category:Source Code Management based on groupsource code.
added Category:Source Code Management label
- Resolved by Igor Drozdov
Avielle's a bit overloaded, so do you mind taking first review @robotmay_gitlab ?
assigned to @robotmay_gitlab and unassigned @avielle
assigned to @igor.drozdov and unassigned @robotmay_gitlab
- Resolved by Igor Drozdov
added 1130 commits
-
1391c7fc...8188bc2d - 1129 commits from branch
master
- 6192cfdd - Run project housekeeping for pull mirrors
-
1391c7fc...8188bc2d - 1129 commits from branch
@nick.thomas Thanks! I apologize for the delay, LGTM
enabled an automatic merge when the pipeline for a22a2b9b succeeds
One more try with the pipeline now !47411 (merged) is merged
mentioned in commit bd6fdc11
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in issue #214092 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label