Skip to content
Snippets Groups Projects

Run project housekeeping for pull mirrors

Merged Nick Thomas requested to merge 214092-gc-when-project-mirroring-fetches into master
All threads resolved!

What does this MR do?

Treats each git fetch into a pull mirror as-if it's a git push into the repository, and enqueues project housekeeping tasks on the same schedule.

This should reduce the storage cost of pull mirrors, which are a small, but noticeable, proportion of the total on GitLab.com

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #214092 (closed)

Edited by Nick Thomas

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nick Thomas resolved all threads

    resolved all threads

  • Author Contributor

    @avielle do you mind giving this a first review? The idea is to make pull mirrors take up less space on disk :)

  • assigned to @avielle

  • Nick Thomas assigned to @robotmay_gitlab and unassigned @avielle

    assigned to @robotmay_gitlab and unassigned @avielle

  • Robert May approved this merge request

    approved this merge request

  • assigned to @igor.drozdov and unassigned @robotmay_gitlab

  • Robert May
  • Nick Thomas added 1130 commits

    added 1130 commits

    Compare with previous version

  • Igor Drozdov resolved all threads

    resolved all threads

  • @nick.thomas Thanks! I apologize for the delay, LGTM :thumbsup:

  • Igor Drozdov approved this merge request

    approved this merge request

  • Igor Drozdov enabled an automatic merge when the pipeline for a22a2b9b succeeds

    enabled an automatic merge when the pipeline for a22a2b9b succeeds

  • Author Contributor

    One more try with the pipeline now !47411 (merged) is merged :sweat_smile:

  • merged

  • Igor Drozdov mentioned in commit bd6fdc11

    mentioned in commit bd6fdc11

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • mentioned in issue #214092 (closed)

  • Please register or sign in to reply
    Loading