Retain spinner when applying MR suggestions
Issue: #250859 (closed)
What does this MR do?
This MR fixes the problem of the non-persisting loading status when users apply suggestion. The solution is to pause the notes polling when a suggestion is being applied.
| Loading | Loading Persists | Result | |
|---|---|---|---|
| Old |  |
|
 |
| This MR | |
|
|
Testing Case
Setup
Please note I manually throttle the network that's why the loading time in the video is sooooo slow
| Download | Upload | Latency |
|---|---|---|
| 50 kb/s | 20 kb/s | 10000ms |
Suggestion
- Go to a Merge Request > Changes tab > Add a suggestion
Batch Suggestion
- Go to a Merge Request > Changes tab > Add a batch suggestion
Follow up Issue
Please note, there is an issue with the solution of pausing the polling. See discussion here > !46203 (comment 446433922). And here's the follow up issue > #285635 (closed)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #250859 (closed)
Edited by Samantha Ming