Add GraphQL argument `healthStatus` to update issue
What does this MR do?
Fixes the sidebar not updating the health status properly.
Related to #268161 (closed)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
added GraphQL devopsplan groupproduct planning typebug labels
mentioned in issue #268161 (closed)
cc @johnhope
@cablett I think you were on the right track here. However, that mutation was moved into
CommonMutationArguments
in !43735 (merged) and included in the update issue mutation.What's strange is that this works for setting weight but not for health status
added backend label
3 Warnings This merge request does not refer to an existing milestone. This MR has a Changelog file outside ee/
, but code changes inee/
. Consider moving the Changelog file intoee/
.You've made some EE-specific changes, but only made changes to FOSS tests.
This could be a sign that you're testing an EE-specific behavior in a FOSS test.Please make sure the spec files pass in AS-IF-FOSS mode either:
- Locally with
FOSS_ONLY=1 bin/rspec -- spec/requests/api/graphql/mutations/issues/update_spec.rb
. - In the MR pipeline by verifying that the
rspec foss-impact
job has passed. - In the MR pipelines by including
RUN AS-IF-FOSS
in the MR title (you can do it with the/title Add GraphQL argument `healthStatus` to update issue [RUN AS-IF-FOSS]
quick action) and start a new MR pipeline.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Pavel Shutsin ( @pshutsin
) (UTC+3, 10 hours behind@cablett
)Jan Provaznik ( @jprovaznik
) (UTC+2, 11 hours behind@cablett
)These files couldn't be categorised, so Danger was unable to suggest a reviewer. Please consider creating a merge request to add support for them.
doc/api/graphql/reference/gitlab_schema.graphql
doc/api/graphql/reference/gitlab_schema.json
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖- Locally with
added 1 commit
- fd181ee4 - Add GraphQL argument `healthStatus` to update issue
added 1 commit
- 0fed93ea - Add GraphQL argument `healthStatus` to update issue
@johnhope closing this one as @jprovaznik's got this one