Skip to content

Fix ENV overridable for codequality

Max Orefice requested to merge mo-fix-env-override-codequality into master

Ref: #11100 (closed)

What does this MR do?

Following up !41318 (comment 409508174).

This MR inlines our propagate_env_vars method in our codequality template.

Why are we doing this?

As @caalberts pointed out, this template does not work outside of gitlab as you can observed on the screenshot below:

code_quality___729490628____Jobs___Maxime_Orefice___test-codequality___GitLab_2020-09-09_12-04-02

This is similar to what we do for our dependency scanning job.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Merge request reports