Add locationHash support to DAST scanner-profile library
What does this MR do?
It adds support for linking directly to a profile tab (site- , or scanner profile) within the DAST on-demand scanner-profile library by setting a location hash to either #site-profiles
or #scanner-profiles
.
Local testing:
- Enable feature flag:
echo "Feature.enable(:security_on_demand_scans_scanner_profiles)" | spring rails c
- Navigate to on-demand scanner profile page:
http://localhost:3000/{grou}/{project}/-/on_demand_scans/profiles
e.g: http://localhost:3000/h5bp/html5-boilerplate/-/on_demand_scans/profiles
-
Append both
#site-profiles
or#scanner-profiles
to the URL and refresh the page. The respective tab should be selected -
Change a tab by clicking on it. The URL should be updated to contain the tab's hash.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #233453 (closed)