Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab
GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 35,811
    • Issues 35,811
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 1,296
    • Merge Requests 1,296
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLabGitLab
  • Merge Requests
  • !40491

Merged
Opened Aug 26, 2020 by Sean Carroll@sean_carroll💬Developer2 of 13 tasks completed2/13 tasks

Allow reporters to approve MRs

  • Overview 47
  • Commits 1
  • Pipelines 24
  • Changes 9

What does this MR do?

Users with Reporter access can be added to a project and also a group, but currently cannot approve MRs if they do not have push access to the branch.

With this MR, when such a group is granted access to Project Approval Rules for a Protected Branch, a Reporter will be able to approve Merge Requests against that protected branch.

Screenshots

update_approval_rule

Does this MR meet the acceptance criteria?

Conformity

  • Changelog entry
  • Documentation (if required)
  • Code review guidelines
  • Merge request performance guidelines
  • Style guides
  • Database guides
  • Separation of EE specific content

Availability and Testing

  • Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
  • Tested in all supported browsers
  • Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #225485 (closed)

Edited Sep 16, 2020 by Sean Carroll
Assignee
Assign to
Reviewer
Request review from
13.4
Milestone
13.4 (Past due)
Assign milestone
Time tracking
Reference: gitlab-org/gitlab!40491
Source branch: 225485-allow-reporters-to-approve-mrs-if-they-are-explicitly-listed-in-the-approval-rules