Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab
GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 34,895
    • Issues 34,895
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 1,229
    • Merge Requests 1,229
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.org
  • GitLabGitLab
  • Merge Requests
  • !39315

Merged
Opened Aug 12, 2020 by Tristan Read@tristan.readDeveloper6 of 6 tasks completed6/6 tasks

Remove the `alert_runbooks` feature flag

  • Overview 9
  • Commits 2
  • Pipelines 4
  • Changes 5

What does this MR do?

Removes the alert_runbooks feature flag, enabling the Metric Alert runbooks.

Issue: #232462 (closed)

Background: The alert_runbooks feature flag was added to aid development (specifically to allow the frontend parts to be merged before the backend). Now that the backend and frontend are merged (!38234 (merged), !38449 (merged)) the feature flag may be safely removed.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

  • Changelog entry
  • [n/a] Documentation (if required) MR here !38661 (merged)
  • Code review guidelines
  • Merge request performance guidelines
  • Style guides
  • [n/a] Database guides
  • [n/a] Separation of EE specific content

Availability and Testing

  • Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
  • Tested in all supported browsers
  • [n/a] Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [n/a] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [n/a] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [n/a] Security reports checked/validated by a reviewer from the AppSec team
Edited Aug 12, 2020 by Tristan Read
Assignee
Assign to
Reviewer
Request review from
13.3
Milestone
13.3 (Past due)
Assign milestone
Time tracking
Reference: gitlab-org/gitlab!39315
Source branch: tr-remove-runbook-feature-flag

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.