Add E2E tests for Group SSO Membership
What does this MR do?
For #214523 (closed)
This MR adds E2E tests for testing the case where
- Group SSO has been set up, with a default membership role (
Developer
) that is not the usual default (Guest
).
And then assert that the newly added member via SSO is added as a Developer
in the group.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %13.3
assigned to @manojmj
added test label
removed Next Up backend customer direction quad-planningcomplete-action typefeature workflowin dev labels
2 Warnings Please add a throughput label to this merge request. You’ve made some app changes, but didn’t add any tests.
That’s OK as long as you’re refactoring existing code,
but please consider adding any of the ~”tooling”, ~”tooling::pipelines”, ~”tooling::workflow”, ~”documentation”, ~”QA” labels.1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 38463 "Add E2E tests for Group SSO Membership"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 38463 "Add E2E tests for Group SSO Membership"
If this merge request doesn’t need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Ragnar Hardarson ( @rhardarson
) (UTC+2, 3.5 hours behind@manojmj
)Martin Wortschack ( @wortschi
) (UTC+2, 3.5 hours behind@manojmj
)QA Sofia Vistas ( @svistas
) (UTC+3, 2.5 hours behind@manojmj
)Maintainer review is optional for QA If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Manoj M J
@sliaquat could you please review?
@kushalpandya could you please review the small frontend change? It is only adding a new QA tag.
Edited by Manoj M J
assigned to @sliaquat and @kushalpandya
unassigned @kushalpandya
added 440 commits
-
606f6c7f...d30746a2 - 439 commits from branch
214523-set-default-role-for-sso-in-gitlab-com
- 4602bff3 - Add E2E tests for Group SSO Membership
-
606f6c7f...d30746a2 - 439 commits from branch
added 536 commits
-
4602bff3...fe9d2fe0 - 535 commits from branch
master
- d1a5caff - Add E2E tests for Group SSO Membership
-
4602bff3...fe9d2fe0 - 535 commits from branch
added 5 commits
-
d1a5caff...be1011fe - 4 commits from branch
master
- b9f4f3c9 - Add E2E tests for Group SSO Membership
-
d1a5caff...be1011fe - 4 commits from branch
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 313d4d0f and 5ca73bea
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.94 MB 3.94 MB - 0.0 % mainChunk 3.09 MB 3.09 MB - 0.0 %
Note: We do not have exact data for 313d4d0f. So we have used data from: 4301dcc3.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Manoj M J
- Resolved by Manoj M J
unassigned @sliaquat
added 667 commits
-
b9f4f3c9...313d4d0f - 665 commits from branch
master
- 4974792b - Add E2E tests for Group SSO Membership
- 09b239d0 - Remove usage of `sign_out_if_signed_in `
-
b9f4f3c9...313d4d0f - 665 commits from branch
The
package-and-qa
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/176474237 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/176480621 downstream.The
Trigger:qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/176480621 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/176498507 downstream.The
gitlab-qa
downstream pipeline failed! .
assigned to @sliaquat
mentioned in commit 8ae7daa4
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
This merge request has been deployed to the release.gitlab.net environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.
This comment is generated automatically using the Release Tools project.added published label
mentioned in issue gitlab-org/quality/quality-engineering/team-tasks#3197