Traversal ids queries

What does this MR do?

Closes #230456 (closed)

Currently to query the namespace hierarchy we must use recursive methods through Gitlab::ObjectHierarchy. We can query the namespace hierarchy a lot faster and easier if we store the path from the root ancestor to each namespace as an attribute on the namespace. We will store this on a new traversal_id attribute on Namespaces.

Say we have this Namespace hierarchy...

graph TD;
    gitlab-->backend;
    backend-->create;
    backend-->manage;
    create-->source;
    manage-->access;
    gitlab-->frontend;

Then the path from gitlab to access is gitlab / backend / manage / access. The path from gitlab to source is gitlab / backend / create / source.

We can use this structure for fast queries. If the current namespace is backend then all our descendants match the path gitlab / backend / *, all our ancestors match the path * / backend, and everyone in the same Namespace hierarchy matches gitlab / *.

We store that path using an array of Namespace ids in a new column on Namespace called traversal_ids.

The recursive Namespace query methods have been moved to a module at app/models/concerns/namespace/recursive_traversal.rb. Feature flags have been included to toggle between using recursive and linear querying methods.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

• Changelog entry
• Documentation (if required)
• Code review guidelines
• Merge request performance guidelines
• Style guides
• Database guides
• Separation of EE specific content

Availability and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• Tested in all supported browsers
• Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• Label as security and @ mention @gitlab-com/gl-security/appsec
• The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• Security reports checked/validated by a reviewer from the AppSec team

app/models/concerns/group_descendant.rb

@@ -7,16 +7,16 @@ module GroupDescendant
   # > project.hierarchy
   # => { parent_group => { child_group => project } }
   def hierarchy(hierarchy_top = nil, preloaded = nil)
-    if self.is_a?(Group) && Feature.enabled?(:linear_groups, root_ancestor)
-      # There is a quirk with the recursive ancestor_upto search where the search continues
-      # until the upto node is reached, or we run out of ancestors to recurse through.
-      # If upto is not an ancestor then the whole ancestor chain is returned. Linear traversal
-      # does not work in this way so we have to drop back to recursive search for now.
-      preloaded ||= Gitlab::ObjectHierarchy.new(self.class.where(id: id))
-                                           .ancestors(upto: hierarchy_top)
-    else
-      preloaded ||= ancestors_upto(hierarchy_top)
-    end
+    # There is a quirk with the recursive ancestor_upto search where the search continues
+    # until the upto node is reached, or we run out of ancestors to recurse through.
+    # If upto is not an ancestor then the whole ancestor chain is returned. Linear traversal
+    # does not work in this way so we have to drop back to recursive search for now.
+    preloaded ||= if self.is_a?(Group) && Feature.enabled?(:linear_groups, root_ancestor)
+                    Gitlab::ObjectHierarchy.new(self.class.where(id: id)).ancestors(upto: hierarchy_top)
+                  else
+                    ancestors_upto(hierarchy_top)
+                  end
+
     expand_hierarchy_for_child(self, self, hierarchy_top, preloaded)
   end