Remove dead endpoint EE::Clusters::ClustersController#metrics
What does this MR do?
During work at #208224 (closed) I've noticed possibly dead code
It looks like #metrics
endpoint in ee/app/controllers/ee/clusters/clusters_controller.rb
is no longer in use. From what I managed to track from repo history it was used to fetch additional metrics. It is passed to vue compenent here b4573bd8 and it is later used by 871bf96c but it not used any more, so instead of moving it to core, we can remove it for codebase.
Endpoint was added gitlab-foss!17139 (5db198fd)
Issue: #225869 (closed)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %13.2
added Category:Metrics Deliverable backend devopsmonitor frontend workflowin dev + 1 deleted label
added 1 commit
- d53ff09d - Remove not used ClustersController#metrics method
added backstage [DEPRECATED] maintenancerefactor labels and removed Deliverable frontend labels
assigned to @mikolaj_wawrzyniak
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Mario de la Ossa ( @mdelaossa
)Markus Koller ( @toupeira
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in issue #208224 (closed)
changed milestone to %13.3
added missed:13.2 label
removed milestone %13.3
added grouprespond label and removed 1 deleted label