Skip to content

Move Alert Detail view to new feature flag

Tristan Read requested to merge tr-alert-detail-feature-flag into master

What does this MR do?

Alert Management is being developed behind the alert_management_minimal feature flag. As part of enabling the feature (#216065 (closed)), we will remove this flag. However, the Detail view is not complete so we want to ensure this is still disabled. The solution for this is to give the detail view its own feature flag: alert_management_detail.

Behavior:

  • Have an alert management alert loaded in the DB
  • Navigate to <project-slug>/-/alert_management/<alert-iid>/details

Result:

  • When alert_management_detail is enabled: See the alert detail page.
  • When alert_management_detail is disabled: See the 404 page.

Issue: #216065 (closed)

No changelog required for this as it's currently behind a feature flag.

Screenshots

alert_management_detail enabled alert_management_detail disabled
Screenshot_2020-05-06_at_16.34.49 Screenshot_2020-05-06_at_16.34.00

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [n/a] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [n/a] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [n/a] Security reports checked/validated by a reviewer from the AppSec team
Edited by Rémy Coutable

Merge request reports