Skip to content
Snippets Groups Projects

Update files when snippet is updated

All threads resolved!

What does this MR do?

When a snippet is updated we have to update the repository content as well. In this MR, we add the necessary actions to update the file path or content in the repository.

Refs #39265 (closed) and #199221 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @mbobin do you mind to review?

  • assigned to @mbobin and unassigned @fjsanpedro

  • added 203 commits

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Sorry @mbobin I have to reassign this to somebody in my group to follow the rules of a pilot we're running.

    @vhawoldar do you mind to review?

  • Francisco Javier López assigned to @vhawoldar and unassigned @mbobin

    assigned to @vhawoldar and unassigned @mbobin

  • added 103 commits

    Compare with previous version

  • Vijay Hawoldar
  • Vijay Hawoldar
  • Vijay Hawoldar
  • @fjsanpedro this is looking great, I've added a few questions but I don't think any of them are really blocking this

  • Vijay Hawoldar assigned to @fjsanpedro and unassigned @vhawoldar

    assigned to @fjsanpedro and unassigned @vhawoldar

  • @vhawoldar do you mind to take another look? :ping_pong:

  • Francisco Javier López assigned to @vhawoldar and unassigned @fjsanpedro

    assigned to @vhawoldar and unassigned @fjsanpedro

  • added 1 commit

    • 62da4e05 - Update snippet repository when snippet updated

    Compare with previous version

  • Vijay Hawoldar assigned to @fjsanpedro and unassigned @vhawoldar

    assigned to @fjsanpedro and unassigned @vhawoldar

  • Vijay Hawoldar approved this merge request

    approved this merge request

  • Thanks @vhawoldar! @smcgivern do you mind to review?

  • assigned to @smcgivern and unassigned @fjsanpedro

  • added 128 commits

    Compare with previous version

  • Sean McGivern
  • Sean McGivern
  • Thanks @fjsanpedro @vhawoldar, looks good! Just a couple of questions.

  • Sean McGivern assigned to @fjsanpedro and unassigned @smcgivern

    assigned to @fjsanpedro and unassigned @smcgivern

  • added 1 commit

    • 94cbb5db - Update snippet repository when snippet updated

    Compare with previous version

  • Reviewer roulette

    Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

    To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.

    Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.

    Category Reviewer Maintainer
    backend Erick Bajao (@iamricecake) Sean McGivern (@smcgivern)

    Generated by :no_entry_sign: Danger

  • @smcgivern I addresses/answered your comments. Another look? :ping_pong:

  • assigned to @smcgivern and unassigned @fjsanpedro

  • Sean McGivern resolved all threads

    resolved all threads

  • Sean McGivern approved this merge request

    approved this merge request

  • Thanks @smcgivern. The Merge widget is raising the error Merge failed: Something went wrong during merge pre-receive hook. API is not accessible. Please try again. :thinking: Can you retry?

  • merged

  • Sean McGivern mentioned in commit 84836fef

    mentioned in commit 84836fef

  • Sean McGivern mentioned in issue #18079

    mentioned in issue #18079

  • Thanks!!!

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • 🤖 GitLab Bot 🤖 changed the description

    changed the description

  • added Category:Source Code Management snippets labels and removed 1 deleted label

  • Please register or sign in to reply
    Loading