Part 3: Abstract pipeline_variables_form to its own component - clean up

What does this MR do and why?

Part 3 for #520831 (closed)

We are abstracting the pipeline variables form to it's own component in order to accommodate inputs work and also hide the component depending on settings.

Part 3 removes the redundant pipeline variables code

Step	MR
Set up component/query	!182376 (merged)
Build out pipeline variable form component	!182455 (merged)
Clean up and integration	[Current MR]

Screenshots or screen recordings

No UI change

How to set up and validate locally

1. Navigate to Build > Pipeline editor and enter the following into your gitlab-ci.yml

variables:
  DEPLOY_ENVIRONMENT:
    value: "staging"
    options:
      - "production"
      - "staging"
      - "canary"
    description: "The deployment target. Set to 'staging' by default."

job:
  script: echo 1

2. Navigate to -/pipelines/new and verify that your variables are output in the pipeline variables form.
3. update variables and click "New pipeline"

Related to #520831 (closed)

changed milestone to %17.10

added devopsverify frontend grouppipeline authoring maintenancerefactor sectionci typemaintenance workflowin dev labels

assigned to @bsandlin

mentioned in merge request !182376 (merged)

added pipelinetier-1 label

mentioned in merge request !182455 (merged)

	7 Warnings
	This merge request is quite big (996 lines changed), please consider splitting it into multiple merge requests.
	b5a1369d: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
	1c7527a1: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
	1c7527a1: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines.
	d8785241: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	There were no new or modified feature flag YAML files detected in this MR. If the changes here are already controlled under an existing feature flag, please add the feature flagexists. Otherwise, if you think the changes here don't need to be under a feature flag, please add the label feature flagskipped, and add a short comment about why we skipped the feature flag. For guidance on when to use a feature flag, please see the documentation.
	This merge request contains lines with testid selectors. Please ensure e2e:test-on-omnibus job is run.

testid selectors

The following changed lines in this MR contain testid selectors:

app/assets/javascripts/ci/pipeline_new/components/pipeline_new_form.vue

-            data-testid="ci-variable-row-container"
-                data-testid="pipeline-form-ci-variable-type"
-                    data-testid="selected-date-range"
-                data-testid="pipeline-form-ci-variable-key-field"
-                data-testid="pipeline-form-ci-variable-value-dropdown"
-                data-testid="pipeline-form-ci-variable-value-field"
-                  data-testid="remove-ci-variable-row"
-                  data-testid="ci-cd-settings-link"

If the e2e:test-on-omnibus job in the qa stage has run automatically, please ensure the tests are passing. If the job has not run, please start the manual:e2e-test-pipeline-generate job in the prepare stage and ensure the tests in follow-up:e2e:test-on-omnibus-ee pipeline are passing.

For the list of known failures please refer to the latest pipeline triage issue.

If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.

Reviewer roulette

Category	Reviewer	Maintainer
frontend	@thomasrandolph (UTC-7, 1 hour behind author)	@tristan.read (UTC+13, 19 hours ahead of author)
QA	@vishal.s.patel (UTC+13, 19 hours ahead of author)	Maintainer review is optional for QA

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

changed the description

added 239 commits

• 55e904d8...b918c0e9 - 236 commits from branch master
• 8314c7ce - Abstract pipeline_variables_form to its own component
• 66bdccf3 - Build out pipeline variables form component
• 3b62d3c9 - Remove redundant code from new pipeline page

Compare with previous version

added 12 commits

• 3b62d3c9...01e36e92 - 8 commits from branch master
• e0364194 - Abstract pipeline_variables_form to its own component
• c54ee732 - Build out pipeline variables form component
• 080f73a0 - Remove redundant code from new pipeline page
• 3446c338 - m

Compare with previous version

added QA label

mentioned in issue #520831 (closed)

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for 2dc470f0

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Govern      | 79     | 0      | 13      | 1     | 92    | ✅     |
| Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
| Verify      | 48     | 0      | 24      | 1     | 72    | ✅     |
| Plan        | 82     | 0      | 8       | 2     | 90    | ✅     |
| Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
| Package     | 24     | 0      | 14      | 1     | 38    | ✅     |
| Create      | 136    | 0      | 22      | 2     | 158   | ✅     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
| Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
| Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
| Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
| Secure      | 5      | 0      | 3       | 1     | 8     | ✅     |
| Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
| Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
| ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 425    | 0      | 131     | 8     | 556   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-test-on-cng: test report for 2dc470f0

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
| Plan        | 82     | 0      | 8       | 0     | 90    | ✅     |
| Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
| Package     | 29     | 0      | 15      | 0     | 44    | ✅     |
| Create      | 136    | 0      | 22      | 0     | 158   | ✅     |
| Verify      | 49     | 0      | 23      | 0     | 72    | ✅     |
| Govern      | 80     | 0      | 12      | 0     | 92    | ✅     |
| Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
| Secure      | 5      | 0      | 3       | 0     | 8     | ✅     |
| Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
| Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
| Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
| Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
| ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
| Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 432    | 0      | 130     | 0     | 562   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

added 15 commits

• 3446c338...177d7c21 - 12 commits from branch master
• 85898623 - Abstract pipeline_variables_form to its own component
• c58d3375 - Build out pipeline variables form component
• ebedecb9 - Remove redundant code from new pipeline page

Compare with previous version

added 15 commits

• 3446c338...177d7c21 - 12 commits from branch master
• 85898623 - Abstract pipeline_variables_form to its own component
• c58d3375 - Build out pipeline variables form component
• ebedecb9 - Remove redundant code from new pipeline page

Compare with previous version

requested review from @lauraXD

changed title from Draft: Part 3: Abstract pipeline_variables_form to its own component to Draft: Part 3: Abstract pipeline_variables_form to its own component - clean up

added 243 commits

• ebedecb9...4d39f5ad - 242 commits from branch master
• 8d7f2fb8 - Remove redundant code from new pipeline page

Compare with previous version

added 424 commits

• 8d7f2fb8...71e7e75a - 423 commits from branch master
• b168f020 - Remove redundant code from new pipeline page

Compare with previous version

added 1 commit

• 8d62808d - Remove redundant code from new pipeline page

Compare with previous version

removed review request for @lauraXD

marked this merge request as ready

changed the description

requested review from @anna_vovchenko

Hey @anna_vovchenko Could you please review this for frontend? I'm thinking it might not need a maintainer since it's mostly code removal and functionality that was tested in the last MR. If you feel it should have a maintainer review, Payton would be a good person to send it to!

added workflowin review label and removed workflowin dev label

removed review request for @anna_vovchenko

requested review from @pburdette

requested review from @anna_vovchenko

removed review request for @pburdette

left review comments without approving or requesting changes

added 99 commits

• 8d62808d...12eac1b7 - 97 commits from branch master
• 9b5ec752 - Remove redundant code from new pipeline page
• 216c7403 - MR feedback - AV

Compare with previous version

requested review from @anna_vovchenko

resolved all threads

approved this merge request

Thanks for the update, @bsandlin! It looks great

added pipeline:mr-approved label

added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label

Before you set this MR to auto-merge

This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

Before you set this MR to auto-merge, please check the following:

• You are the last maintainer of this merge request
• The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
• This pipeline is recent enough (created in the last 8 hours)

If all the criteria above apply, please set auto-merge for this merge request.

See pipeline tiers and merging a merge request for more details.

enabled automatic add to merge train when checks pass

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 927253a6 and 2dc470f0

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	4.95 MB	4.95 MB	-	-0.0 %
mainChunk	3.88 MB	3.88 MB	-	0.0 %

Significant Reduction: 1

Expand

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
pages.projects.pipelines.new	305.38 KB	289.56 KB	-15.83 KB	-5.2 %

---

Note: We do not have exact data for 927253a6. So we have used data from: 2fdc69a4.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun the bundle-size-review job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

Please look at the full report for more details

---

Read more about how this report works.

Generated by Danger

@anna_vovchenko Unfortunately, these QA failures are legitimate.

@treagitlab wrote you a message in the slack channel

aborted automatic add to merge train because the source branch was updated. Learn more.

added 253 commits

• 216c7403...e1dc121b - 250 commits from branch master
• f33fcefe - Remove redundant code from new pipeline page
• cd465434 - MR feedback - AV
• 819d3460 - update specs

Compare with previous version

reset approvals from @anna_vovchenko by pushing to the branch

added 67 commits

• 819d3460...0f33ab34 - 64 commits from branch master
• b5a1369d - Remove redundant code from new pipeline page
• d8785241 - MR feedback - AV
• 1c7527a1 - update specs

Compare with previous version

mentioned in issue #523094

added 1 commit

• 2dc470f0 - Quarantine prefilled and custom variable specs for investigation

Compare with previous version

requested review from @anna_vovchenko

resolved all threads

requested review from @lauraXD

approved this merge request

resolved all threads

enabled automatic add to merge train when checks pass

started a merge train

merged

mentioned in commit 906aaafd

mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#10867 (closed)

added workflowstaging-canary label and removed workflowin review label

added workflowcanary label and removed workflowstaging-canary label

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

added workflowpost-deploy-db-staging label and removed workflowproduction label