Apply styling change requests in milestone search ready for dark mode
What does this MR do and why?
This MR contains 3 changes (as requested in this figma doc https://www.figma.com/design/7MczJosYzQM3PbuqOpr7WS/Dark-mode-%3E-Global-Search-Evaluation?node-id=6066-494&m=dev):
- Replaces gl-badge use with small subtle text to be in line with rest of page styling
- Makes milestone title styled as a link
- Removes the bottom margin from the last
<p>
tag in a milestone description (this is converted from markdown, only removing the last<p>
so that if there are others they retain their margin. More information on how this works can be found in the MR that introduces this change: !56256 (diffs))
References
Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Related to #519779 (closed)
Merge request reports
Activity
assigned to @jrushford
added pipelinetier-1 label
2 Warnings The master pipeline status page reported failures in If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
Please check for any on-going incidents in the incident issue tracker or in the#master-broken
Slack channel.You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, maintenanceperformance, documentation, QA labels.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @arpitgogia
(UTC+5.5, 4.5 hours ahead of author)
@hmehra
(UTC+11, 10 hours ahead of author)
frontend @dzubova
(UTC+1, same timezone as author)
@apennells
(UTC-5, 6 hours behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by ****- Resolved by Kos Palchyk
Hey @kpalchyk would you mind please reviewing this MR? skipping intila due to simplicity
requested review from @kpalchyk
added pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
changed milestone to %17.10
removed backend label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 9d994219 and 90033f45
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.88 MB 4.88 MB - 0.0 % mainChunk 3.78 MB 3.78 MB - 0.0 %
Note: We do not have exact data for 9d994219. So we have used data from: f05d8220.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by ****E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-cng:
test report for 90033f45expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 84 | 0 | 10 | 0 | 94 | ✅ | | Create | 140 | 0 | 22 | 0 | 162 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Package | 29 | 0 | 15 | 0 | 44 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Verify | 52 | 0 | 20 | 0 | 72 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Secure | 3 | 0 | 5 | 0 | 8 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 445 | 0 | 127 | 0 | 572 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-gdk:
test report for 90033f45expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 135 | 0 | 23 | 0 | 158 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Govern | 79 | 0 | 13 | 0 | 92 | ✅ | | Verify | 51 | 0 | 21 | 0 | 72 | ✅ | | Plan | 82 | 0 | 8 | 0 | 90 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Secure | 5 | 0 | 3 | 0 | 8 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 427 | 0 | 129 | 0 | 556 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
Edited by ****added backend label
started a merge train
mentioned in commit d0f2c0de
mentioned in issue #519779 (closed)
added workflowstaging-canary label and removed workflowstart label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label