Skip to content
Snippets Groups Projects

Resolve "Ensure after_script is called for timed out pipelines"

All threads resolved!

What does this MR do?

This MR improves the documentation regarding RUNNER_SCRIPT_TIMEOUT and RUNNER_AFTER_SCRIPT_TIMEOUT by adding an example of how to configure correctly jobs so that after_script runs through.

Related issues

Related to #15603

Author's checklist

If you are a GitLab team member and only adding documentation, do not add any of the following labels:

  • ~"frontend"
  • ~"backend"
  • ~"type::bug"
  • ~"database"

These labels cause the MR to be added to code verification QA issues.

Reviewer's checklist

Documentation-related MRs should be reviewed by a Technical Writer for a non-blocking review, based on Documentation Guidelines and the Style Guide.

If you aren't sure which tech writer to ask, use roulette or ask in the #docs Slack channel.

  • If the content requires it, ensure the information is reviewed by a subject matter expert.
  • Technical writer review items:
    • Ensure docs metadata is present and up-to-date.
    • Ensure the appropriate labels are added to this MR.
    • Ensure a release milestone is set.
    • If relevant to this MR, ensure content topic type principles are in use, including:
      • The headings should be something you'd do a Google search for. Instead of Default behavior, say something like Default behavior when you close an issue.
      • The headings (other than the page title) should be active. Instead of Configuring GDK, say something like Configure GDK.
      • Any task steps should be written as a numbered list.
      • If the content still needs to be edited for topic types, you can create a follow-up issue with the docs-technical-debt label.
  • Review by assigned maintainer, who can always request/require the reviews above. Maintainer's review can occur before or after a technical writer review.
Edited by Daniel P.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Cheryl Li requested review from @marcel.amirault

    requested review from @marcel.amirault

  • Daniel P. added 1 commit

    added 1 commit

    • 521b48d2 - Simplify explanation of script timeouts

    Compare with previous version

  • Axel von Bertoldi resolved all threads

    resolved all threads

  • Daniel P. resolved all threads

    resolved all threads

  • Daniel P. added 1 commit

    added 1 commit

    • 12eeca13 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Marcel Amirault requested review from @lyspin

    requested review from @lyspin

  • Marcel Amirault removed review request for @marcel.amirault

    removed review request for @marcel.amirault

  • Daniel P. marked this merge request as ready

    marked this merge request as ready

  • Lysanne Pinto
  • @daniel-prause Thanks for this MR! I added a couple suggestions :ping_pong:

  • Daniel P. added 1 commit

    added 1 commit

    • 8e63cf9d - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Daniel P. added 1 commit

    added 1 commit

    • 44a5bd6a - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Daniel P. added 1 commit

    added 1 commit

    • 38fde3d5 - Move insurance of running after script

    Compare with previous version

  • Lysanne Pinto changed milestone to %17.10

    changed milestone to %17.10

  • Lysanne Pinto added 1 commit

    added 1 commit

    Compare with previous version

  • Lysanne Pinto resolved all threads

    resolved all threads

  • Lysanne Pinto approved this merge request

    approved this merge request

  • Hi @lyspin :wave:,

    GitLab Bot has added the Technical Writing label because a Technical Writer has approved or merged this MR.

    This message was generated automatically. Improve it or delete it.

  • Lysanne Pinto enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Daniel P. marked the checklist item Follow the: as completed

    marked the checklist item Follow the: as completed

  • @daniel-prause I pushed a small change, approved, and set this to merge :rocket:

  • merged

  • Lysanne Pinto mentioned in commit 4adb4560

    mentioned in commit 4adb4560

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading