Show message when approaching Pages deployments limit

changed milestone to %17.9

added Category:Pages Pages:UI featureaddition groupknowledge typefeature labels

assigned to @janis

added pipelinetier-1 label

added devopsplan sectiondev labels

changed the description

added backend frontend labels

1 Warning

⚠️

featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.

For more information, see:

The Handbook page on merge request types.
The definition of done documentation.

Reviewer roulette

Category	Reviewer	Maintainer
backend	`@zhaochen_li` (UTC+11, 10 hours ahead of author)	`@sashi_kumar` (UTC+0, 1 hour behind author)
frontend	`@fernando-c` (UTC-6, 7 hours behind author)	`@cngo` (UTC+0, 1 hour behind author)
test for `spec/features/*`	`@zhaochen_li` (UTC+11, 10 hours ahead of author)	Maintainer review is optional for test for `spec/features/*`

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the 🔁 danger-review job that generated this comment.

Generated by 🚫 Danger

@afracazo @msedlakjakubowski, here's the quick fix for this issue so we can make GA in 17.9. Can I get some feedback on the wording on this?

I've opted for a design with an inline link instead of an action button, since the button made the alert way too big for the issue its describing imo, but feel free to override this decision.

cc @mmacfarlane

requested review from @msedlakjakubowski and @afracazo

approved this merge request

added Technical Writing UI text twfinished workflowin review labels

added pipeline:mr-approved label

added pipelinetier-2 label and removed pipelinetier-1 label

Before you set this MR to auto-merge

This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

Before you set this MR to auto-merge, please check the following:

You are the last maintainer of this merge request
The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
This pipeline is recent enough (created in the last 8 hours)

If all the criteria above apply, please set auto-merge for this merge request.

See pipeline tiers and merging a merge request for more details.

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: ✅ test report for 2072a3fe

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Verify      | 48     | 0      | 2       | 0     | 50    | ✅     |
| Plan        | 79     | 0      | 1       | 0     | 80    | ✅     |
| Package     | 24     | 0      | 0       | 0     | 24    | ✅     |
| Data Stores | 28     | 0      | 0       | 0     | 28    | ✅     |
| Create      | 123    | 0      | 3       | 0     | 126   | ✅     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| Govern      | 59     | 0      | 3       | 0     | 62    | ✅     |
| Monitor     | 8      | 0      | 1       | 0     | 9     | ✅     |
| Secure      | 4      | 0      | 0       | 0     | 4     | ✅     |
| Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
| Manage      | 1      | 0      | 0       | 0     | 1     | ✅     |
| Fulfillment | 1      | 0      | 0       | 0     | 1     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 382    | 0      | 10      | 0     | 392   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-test-on-cng: ✅ test report for 2072a3fe

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Plan        | 86     | 0      | 8       | 0     | 94    | ✅     |
| Govern      | 84     | 0      | 10      | 0     | 94    | ✅     |
| Package     | 29     | 0      | 15      | 0     | 44    | ✅     |
| Verify      | 52     | 0      | 20      | 0     | 72    | ✅     |
| Create      | 140    | 0      | 22      | 0     | 162   | ✅     |
| Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
| Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
| Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
| Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| Secure      | 2      | 0      | 5       | 0     | 7     | ✅     |
| Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
| Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
| Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
| Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
| ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 444    | 0      | 127     | 0     | 571   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

added 1 commit

0e08ab70 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 3 commits

dfa92ffa - Include period after link
75fab919 - Add feature spec for the warning
2dde9df2 - Update translation file

Compare with previous version

approved this merge request

added 1 commit

535a1d04 - Stub license query to fix rspec

Compare with previous version

@afrnz would you mind reviewing backend and test for me?

requested review from @afrnz

@fdegier would you review frontend, please?

requested review from @fdegier

requested review from @GitLabDuo

I have reviewed the code changes and left two recommendations regarding the removal of the limit variable and its usage. The review covers potential issues with deployment counting and consistency between different project types. I estimate there is a small amount of work required to address these concerns, but this is only an estimate based on the provided comments.

removed review request for @GitLabDuo

approved this merge request

requested review from @tbulva

added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label

mentioned in issue #456358 (closed)

changed the description

approved this merge request

requested review from @pskorupa

I've realised that I had made a mistake and used the project level count to compare against the limit, even though I should be using the domain level count (that may differ if using a namespace domain). I've fixed that, @afrnz, could you take another look?