File browser code owner badge size alignment
What does this MR do and why?
Fixes the changing position of Code Owner content (Toggle) and the badge size (1px shift).
References
Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
MR acceptance checklist
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
- http://gdk.test:3000/flightjs/Flight
- Use file browser with some Code Owner rules applied
Related to #499696 (closed)
Closes #510466 (closed)
Merge request reports
Activity
changed milestone to %17.8
assigned to @seggenberger
requested review from @jeldergl
added devopsfoundations groupux paper cuts sectioncore platform labels
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels
added UX UX Paper Cuts frontend maintenancerefactor sectiondev typemaintenance labels and removed sectioncore platform label
added bugux typebug labels and removed typemaintenance label
removed maintenancerefactor label
added groupsource code label and removed groupux paper cuts label
added Category:Source Code Management label
added 10072 commits
-
7ee59d35...bd938644 - 10070 commits from branch
master
- f89b5920 - Update .gitlab-ci.yml file
- be85ed6f - File browser: Fix position of Code owner content and badge
-
7ee59d35...bd938644 - 10070 commits from branch
- Resolved by Sascha Eggenberger
mentioned in issue #510466 (closed)
2 Warnings You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, maintenanceperformance, documentation, QA labels.This merge request changed undocumented Vue components in
vue_shared/
. Please consider creating Stories for these components:ee/app/assets/javascripts/vue_shared/components/code_owners/code_owners.vue
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer frontend @dstull
(UTC-5, 6 hours behind author)
@ankit.panchal
(UTC+5.5, 4.5 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits bd938644 and be85ed6f
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.42 MB 4.42 MB - 0.0 % mainChunk 3.28 MB 3.28 MB - 0.0 %
Note: We do not have exact data for bd938644. So we have used data from: 4f11f681.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerE2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for be85ed6fexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Plan | 82 | 0 | 8 | 0 | 90 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Govern | 80 | 0 | 12 | 0 | 92 | ✅ | | Package | 25 | 0 | 13 | 0 | 38 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Create | 135 | 0 | 20 | 0 | 155 | ✅ | | Verify | 50 | 0 | 16 | 0 | 66 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Secure | 4 | 0 | 3 | 0 | 7 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 427 | 0 | 119 | 0 | 546 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for be85ed6fexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Create | 140 | 0 | 19 | 0 | 159 | ✅ | | Verify | 51 | 0 | 15 | 0 | 66 | ✅ | | Govern | 84 | 0 | 10 | 0 | 94 | ✅ | | Secure | 2 | 0 | 5 | 0 | 7 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Package | 30 | 0 | 14 | 0 | 44 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 444 | 0 | 118 | 0 | 562 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
Edited by ****- Resolved by Sascha Eggenberger
@ankit.panchal can you take a look here?
requested review from @ankit.panchal
added pipeline:mr-approved label
2 Warnings You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, maintenanceperformance, documentation, QA labels.This merge request changed undocumented Vue components in
vue_shared/
. Please consider creating Stories for these components:ee/app/assets/javascripts/vue_shared/components/code_owners/code_owners.vue
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer frontend @agulina
(UTC+1, same timezone as author)
@psjakubowska
(UTC+1, same timezone as author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits c083c339 and be85ed6f
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.42 MB 4.42 MB - 0.0 % mainChunk 3.28 MB 3.28 MB - 0.0 %
Note: We do not have exact data for c083c339. So we have used data from: 55bb3fdc.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded this merge request to the merge train at position 2
mentioned in commit b4c6ffea
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label