Remove unused feature flags from custom abilities
What does this MR do and why?
- This MR cleans up the custom ability definitions, since the feature flags specified in them no longer exist.
- Updates the custom roles doc to add a step on how new custom abilities can be added with a feature flag.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Merge request reports
Activity
assigned to @hmehra
added pipelinetier-1 label
- A deleted user
1 Warning This merge request does not refer to an existing milestone. 2 Messages This MR contains docs in the /doc/development directory, but any Maintainer (other than the author) can merge. You do not need tech writer review. This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/user/custom_roles/abilities.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Category Reviewer Maintainer backend @jon_jenkins
(UTC-6, 17 hours behind author)
@mhamda
(UTC+1, 10 hours behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
mentioned in merge request !175793 (merged)
- Resolved by Jarka Košanová
requested review from @imand3r
requested review from @jarka
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 1ae2476bexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Govern | 80 | 0 | 12 | 0 | 92 | ✅ | | Create | 135 | 0 | 20 | 0 | 155 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Plan | 82 | 0 | 8 | 0 | 90 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Verify | 50 | 0 | 16 | 0 | 66 | ✅ | | Secure | 4 | 0 | 3 | 0 | 7 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Package | 25 | 0 | 13 | 0 | 38 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 427 | 0 | 119 | 0 | 546 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for 1ae2476bexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Package | 30 | 0 | 14 | 0 | 44 | ✅ | | Verify | 51 | 0 | 15 | 0 | 66 | ✅ | | Create | 140 | 0 | 19 | 1 | 159 | ✅ | | Govern | 84 | 0 | 10 | 0 | 94 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Secure | 2 | 0 | 5 | 0 | 7 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 444 | 0 | 118 | 1 | 562 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
mentioned in issue gitlab-com/www-gitlab-com#13970 (closed)
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
Thanks @hmehra , setting auto-merge
started a merge train
mentioned in commit 42b432e1
mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#9839 (closed)
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowproduction label and removed workflowcanary label
added workflowstaging label and removed workflowproduction label
changed milestone to %17.8
added workflowpost-deploy-db-staging label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label