Skip to content
Snippets Groups Projects

Fix resetting timer on ChunkWriter

Merged Stanislav Lashmanov requested to merge slashmanov/fix-chunk-writer-resetting-timer into master
All threads resolved!

What does this MR do and why?

This MR fixes resetting timer on ChunkWriter on each chunk write, which led to write throttling to be impossible.

How to set up and validate locally

  1. Enable rapid_diffs feature flag
  2. Add { minChunkSize: 9999999, maxChunkSize: 9999999 timeout: 99999 } as a third argument to renderHtmlStreams in merge request Rapid Diffs
  3. Go to any merge request changes page with more than 20 files changes
  4. Add ?rapid_diffs=true to the URL and open it
  5. Observe that an HTML chunk is inserted only when the stream completes
  6. Observe that HTML is streamed in smaller chunks when you decrease the timeout option (set it to 200 for example)
Edited by Stanislav Lashmanov

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Reviewer roulette

    Category Reviewer Maintainer
    frontend @aalakkad profile link current availability (UTC+3, 1 hour behind author) @psjakubowska profile link current availability (UTC+1, 3 hours behind author)

    Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Stanislav Lashmanov changed the description

    changed the description

  • requested review from @lindsey-shelton

  • Lindsey Shelton approved this merge request

    approved this merge request

  • requested review from @psjakubowska

  • added pipelinetier-2 label and removed pipelinetier-1 label

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 89d61b1e and 04f347b3

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.42 MB 4.42 MB - 0.0 %
    mainChunk 3.28 MB 3.28 MB - 0.0 %

    Note: We do not have exact data for 89d61b1e. So we have used data from: 0e2021b6.
    The intended commit has no webpack pipeline, so we chose the last commit with one before it.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 04f347b3

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
    | Plan        | 82     | 0      | 8       | 0     | 90    | ✅     |
    | Create      | 135    | 0      | 20      | 0     | 155   | ✅     |
    | Package     | 25     | 0      | 13      | 0     | 38    | ✅     |
    | Secure      | 4      | 0      | 3       | 0     | 7     | ✅     |
    | Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
    | Govern      | 80     | 0      | 12      | 0     | 92    | ✅     |
    | Verify      | 50     | 0      | 16      | 1     | 66    | ✅     |
    | Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
    | Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
    | Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
    | Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
    | ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 427    | 0      | 119     | 1     | 546   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-cng: :white_check_mark: test report for 04f347b3

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Plan        | 86     | 0      | 8       | 0     | 94    | ✅     |
    | Package     | 30     | 0      | 14      | 0     | 44    | ✅     |
    | Govern      | 84     | 0      | 10      | 0     | 94    | ✅     |
    | Create      | 140    | 0      | 19      | 1     | 159   | ✅     |
    | Verify      | 51     | 0      | 15      | 0     | 66    | ✅     |
    | ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
    | Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
    | Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
    | Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
    | Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
    | Secure      | 2      | 0      | 5       | 0     | 7     | ✅     |
    | Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
    | Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 444    | 0      | 118     | 1     | 562   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • Paulina Sedlak-Jakubowska approved this merge request

    approved this merge request

  • resolved all threads

  • Paulina Sedlak-Jakubowska enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • mentioned in commit 756ba26b

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading