Commit statuses api add filter on pipeline_id and sort

• Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you receive complimentary access to GitLab Duo.

What does this MR do and why?

• Filter commit statuses by pipeline id
• Sort commit statuses by asc and desc (today it is only asc) and ordered by id and pipeline_id (today only by id)

Signed-off-by: guillaume.micouin-jorda gmicouin@netcourrier.com

lib/api/commit_statuses.rb

@@ -116,10 +116,10 @@ def optional_commit_status_params
           attributes_for_keys(updatable_optional_attributes)
         end
 
-        # rubocop: disable CodeReuse/ActiveRecord
+        # rubocop: disable CodeReuse/ActiveRecord -- Better code maintainability here, this won't be reused anywhere
         def order_and_sort_statuses(statuses)
-          sort = params[:sort].presence || "asc"
-          statuses.order(params[:order_by] == 'pipeline_id' ? params[:order_by] : "id" => sort)
+          sort = params[:sort].presence || DEFAULT_SORT_DIRECTION
+          statuses.order(params[:order_by] == 'pipeline_id' ? params[:order_by] : DEFAULT_SORT_VALUE => sort)
         end
         # rubocop: enable CodeReuse/ActiveRecord
       end