Remove move_ai_tracking_to_instrumentation_layer FF
What does this MR do and why?
This MR removes `move_ai_tracking_to_instrumentation_layer as it was concluded the new changes dont have any side effects.
Rollout issue #506471 (closed)
Implementation issue !167415 (merged)
References
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Related to #506471 (closed)
Merge request reports
Activity
changed milestone to %17.8
assigned to @nbelokolodov
added 1 commit
- 5bf9fcb2 - Remove move_ai_tracking_to_instrumentation_layer feature flag
- A deleted user
added backend label
Reviewer roulette
Category Reviewer Maintainer backend @tvellishetty
(UTC+5.5, 7.5 hours behind author)
@brytannia
(UTC+1, 12 hours behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 1 commit
- 54b5ed31 - Remove move_ai_tracking_to_instrumentation_layer feature flag
changed milestone to %17.9
added missed:17.8 label
added 2540 commits
-
54b5ed31...47d2a4d2 - 2539 commits from branch
master
- 53d3fe1b - Remove move_ai_tracking_to_instrumentation_layer feature flag
-
54b5ed31...47d2a4d2 - 2539 commits from branch
1 Warning The master pipeline status page reported failures in If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
Please check for any on-going incidents in the incident issue tracker or in the#master-broken
Slack channel.Reviewer roulette
Category Reviewer Maintainer backend @tgao3701908
(UTC-5, 18 hours behind author)
@drew
(UTC+0, 13 hours behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by ****mentioned in issue #512259 (closed)
added 455 commits
-
53d3fe1b...7d08ba56 - 454 commits from branch
master
- 34189f56 - Remove move_ai_tracking_to_instrumentation_layer feature flag
-
53d3fe1b...7d08ba56 - 454 commits from branch
@felipe_artur could you please review?
requested review from @felipe_artur
@nbelokolodov Looks good to me. Thanks.
added pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels
requested review from @hfyngvason
- Resolved by Hordur Freyr Yngvason
Thanks @nbelokolodov! The code changes look good to me, but as someone without much surrounding context for the change, how would I go about verifying this claim?
as it was concluded the new changes dont have any side effects.
Would you mind elaborating a bit more about what could have broken and present some evidence that it did not? Nothing fancy, just write a short comment on the rollout issue explaining what validation steps you performed and their outcome, and link that here please
added 1136 commits
-
34189f56...68dc2675 - 1135 commits from branch
master
- 290224cb - Remove move_ai_tracking_to_instrumentation_layer feature flag
-
34189f56...68dc2675 - 1135 commits from branch
reset approvals from @felipe_artur and @hfyngvason by pushing to the branch
Generated bygitlab_quality-test_tooling
.
Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.Click to expand
Job File Name Duration Expected duration #8912469238 ee/spec/lib/ee/gitlab/usage_data_spec.rb#L238
Gitlab::UsageData usage_activity_by_stage_create includes accurate usage_activity_by_stage data 30.26 s < 27.12 s #8915344127 ee/spec/lib/ee/gitlab/usage_data_spec.rb#L238
Gitlab::UsageData usage_activity_by_stage_create includes accurate usage_activity_by_stage data 28.83 s < 27.12 s #8915344067 ee/spec/lib/ee/gitlab/usage_data_spec.rb#L238
Gitlab::UsageData usage_activity_by_stage_create includes accurate usage_activity_by_stage data 32.98 s < 27.12 s Edited by ****added rspec:slow test detected label
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-cng:
test report for 867dc5a2expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 143 | 0 | 19 | 0 | 162 | ✅ | | Verify | 51 | 0 | 19 | 0 | 70 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Govern | 84 | 0 | 10 | 0 | 94 | ✅ | | Package | 30 | 0 | 14 | 0 | 44 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Secure | 2 | 0 | 5 | 0 | 7 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 447 | 0 | 122 | 0 | 569 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-gdk:
test report for 867dc5a2expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 79 | 0 | 13 | 0 | 92 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Plan | 82 | 0 | 8 | 0 | 90 | ✅ | | Create | 138 | 0 | 20 | 0 | 158 | ✅ | | Package | 25 | 0 | 13 | 0 | 38 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Secure | 4 | 0 | 3 | 0 | 7 | ✅ | | Verify | 50 | 0 | 20 | 0 | 70 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 429 | 0 | 124 | 0 | 553 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
Edited by ****aborted automatic add to merge train because the source branch was updated. Learn more.
reset approvals from @hfyngvason by pushing to the branch
- Resolved by Hordur Freyr Yngvason
requested review from @felipe_artur
- Resolved by Hordur Freyr Yngvason
added 431 commits
-
40afbee3...c07eb78b - 429 commits from branch
master
- c39276dc - Remove move_ai_tracking_to_instrumentation_layer feature flag
- 867dc5a2 - Remove expected hash from shared example
-
40afbee3...c07eb78b - 429 commits from branch
requested review from @hfyngvason
added this merge request to the merge train at position 2
mentioned in commit a9572a3a
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label