Fix flaky tests finding current Geo node

What does this MR do and why?

I am not sure what state is leaking but it is likely from some other Geo test (or maybe more than one). These affected tests are "finding" a Geo node in the DB with a name that matches the machine's "Geo node name". These tests expect to NOT find such a match.

I tried rspec --bisect with one of the sets of specs in one of the failed jobs, but it did not reproduce the failure.

All three related issues were created around a week ago. I looked through MRs that were merged around that time and didn't find anything suspicious.

As a quick fix, I'm making these tests more robust by stubbing the methods they check in order to determine that 1) rows do exist in the geo_nodes table, and 2) none of those rows have a name that matches this machine's "Geo node name".

This quick fix is reasonable, since Geo tests with this kind of setup are rare.

References

Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

• Resolves [Test] ee/spec/lib/geo/console/troubleshoot_rep... (#508648 - closed)
• Resolves [Test] ee/spec/lib/system_check/rake_task/geo_t... (#508429 - closed)
• Resolves [Test] ee/spec/lib/geo/console/main_menu_spec.r... (#508441 - closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

changed milestone to %17.8

added Category:Geo-replication automation:bot-authored devopstenant scale failureflaky-test flakiness3 groupgeo priority3 sectioninfrastructure platforms severity3 test test-health:pass-after-retry typemaintenance workflowin dev labels

assigned to @mkozono

removed workflowin dev label

removed automation:bot-authored label

removed test-health:pass-after-retry label

removed flakiness3 label

added pipelinetier-1 label

added backend label

1 Warning

The master pipeline status page reported failures in rspec system pg14 30/32 rspec system pg14 10/32 rspec-ee integration pg14 9/9 rspec-ee unit pg14 26/39 rspec integration pg14 20/20 rspec integration pg14 11/20 rspec integration pg14 9/20 rspec integration pg14 8/20 rspec unit pg14 39/44 rspec unit pg14 36/44 rspec unit pg14 27/44 rspec unit pg14 16/44 rspec unit pg14 14/44 rspec unit pg14 10/44 rspec background_migration pg14 17/17 rspec background_migration pg14 16/17 rspec background_migration pg14 15/17 rspec background_migration pg14 14/17 rspec background_migration pg14 13/17 rspec background_migration pg14 12/17 rspec background_migration pg14 11/17 rspec background_migration pg14 10/17 rspec background_migration pg14 9/17 rspec background_migration pg14 7/17 rspec background_migration pg14 6/17 rspec background_migration pg14 5/17 rspec background_migration pg14 3/17 rspec background_migration pg14 2/17 rspec background_migration pg14 1/17 If these jobs fail in your merge request with the same errors, then they are not caused by your changes. Please check for any on-going incidents in the incident issue tracker or in the #master-broken Slack channel.

	1 Message
	CHANGELOG missing: If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog. If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Category	Reviewer	Maintainer
backend	@shubhamkrai (UTC+1, 11 hours ahead of author)	@digitalmoksha (UTC-6, 4 hours ahead of author)

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

changed the description

requested review from @GitLabDuo

I finished my review and found nothing to comment on. Nice work!

requested review from @nsilva5 and removed review request for @GitLabDuo

Changes LGTM, I can see that they make the tests more robust, but I'm having trouble understanding the flaky part of it.

approved this merge request

added pipeline:mr-approved label

added pipelinetier-2 label and removed pipelinetier-1 label

Before you set this MR to auto-merge

This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

Before you set this MR to auto-merge, please check the following:

• You are the last maintainer of this merge request
• The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
• This pipeline is recent enough (created in the last 8 hours)

If all the criteria above apply, please set auto-merge for this merge request.

See pipeline tiers and merging a merge request for more details.

requested review from @suraj_tripathy

mentioned in issue #493890 (closed)

approved this merge request

added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label

resolved all threads

enabled automatic add to merge train when checks pass

started a merge train

merged

mentioned in commit 3a61b2ec

mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#9712 (closed)

added workflowstaging-canary label

added workflowcanary label and removed workflowstaging-canary label

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

added workflowpost-deploy-db-staging label and removed workflowproduction label

added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label

mentioned in issue #508441 (closed)

mentioned in issue #508648 (closed)

mentioned in issue #508429 (closed)

added releasedcandidate label

added releasedpublished label and removed releasedcandidate label