Skip to content
Snippets Groups Projects

Clarify runner plan limits

Merged Pedro Pombeiro requested to merge pedropombeiro/clarify-runner-plan-limits into master
All threads resolved!

What does this MR do and why?

This MR is a follow-up to !175505 (merged) to try and clarify how runner plan limits are enforced, due to some confusion witnessed during the https://gitlab.com/gitlab-com/gl-infra/production/-/issues/18994 incident.

References

Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots

Before After
image image
Edited by Pedro Pombeiro

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • requested changes

  • Pedro Pombeiro added 135 commits

    added 135 commits

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • requested review from @rsarangadharan

  • Roshni Sarangadharan approved this merge request

    approved this merge request

  • added pipelinetier-2 label and removed pipelinetier-1 label

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • A deleted user added backend label

    added backend label

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for b65938f0

    expand test summary
    +-------------------------------------------------------------+
    |                       suites summary                        |
    +--------+--------+--------+---------+-------+-------+--------+
    |        | passed | failed | skipped | flaky | total | result |
    +--------+--------+--------+---------+-------+-------+--------+
    | Verify | 1      | 0      | 0       | 0     | 1     | ✅     |
    | Create | 1      | 0      | 0       | 0     | 1     | ✅     |
    +--------+--------+--------+---------+-------+-------+--------+
    | Total  | 2      | 0      | 0       | 0     | 2     | ✅     |
    +--------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-cng: :white_check_mark: test report for b65938f0

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Create      | 140    | 0      | 19      | 0     | 159   | ✅     |
    | Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
    | Verify      | 50     | 0      | 15      | 0     | 65    | ✅     |
    | Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
    | Package     | 24     | 0      | 14      | 0     | 38    | ✅     |
    | Plan        | 86     | 0      | 8       | 0     | 94    | ✅     |
    | Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
    | Govern      | 84     | 0      | 10      | 0     | 94    | ✅     |
    | Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
    | Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Secure      | 2      | 0      | 5       | 0     | 7     | ✅     |
    | Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
    | ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 437    | 0      | 118     | 0     | 555   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • added 1 commit

    Compare with previous version

  • added UI text label

  • Pedro Pombeiro requested review from @rsarangadharan and removed approval

    requested review from @rsarangadharan and removed approval

  • Pedro Pombeiro changed the description

    changed the description

  • Roshni Sarangadharan approved this merge request

    approved this merge request

  • Darren Eastman approved this merge request

    approved this merge request

  • Pedro Pombeiro resolved all threads

    resolved all threads

  • Pedro Pombeiro enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Pedro Pombeiro cancelled automatic add to merge train

    cancelled automatic add to merge train

  • Hey @mrincon :waves:, mind doing the maintainer review?

  • Pedro Pombeiro requested review from @mrincon

    requested review from @mrincon

  • Miguel Rincon approved this merge request

    approved this merge request

  • Pedro Pombeiro enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Pedro Pombeiro mentioned in commit 6aa3df52

    mentioned in commit 6aa3df52

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading