Clarify runner plan limits
What does this MR do and why?
This MR is a follow-up to !175505 (merged) to try and clarify how runner plan limits are enforced, due to some confusion witnessed during the https://gitlab.com/gitlab-com/gl-infra/production/-/issues/18994 incident.
References
Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots
Before | After |
---|---|
![]() |
![]() |
Merge request reports
Activity
changed milestone to %17.8
added Category:Fleet Visibility devopsverify grouprunner sectionci labels
assigned to @pedropombeiro
added pipelinetier-1 label
- A deleted user
added backend documentation labels
1 Warning There were no new or modified feature flag YAML files detected in this MR. If the changes here are already controlled under an existing feature flag, please add
the feature flagexists. Otherwise, if you think the changes here don't need
to be under a feature flag, please add the label feature flagskipped, and
add a short comment about why we skipped the feature flag.For guidance on when to use a feature flag, please see the documentation.
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/administration/settings/continuous_integration.md
(Link to current live version) -
doc/api/plan_limits.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Category Reviewer Maintainer backend @tvellishetty
(UTC+5.5, 4.5 hours ahead of author)
@dblessing
(UTC-6, 7 hours behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
added Technical Writing label and removed backend label
/Hey @rsarangadharan
, mind doing the documentation review?requested review from @rsarangadharan
- Resolved by Roshni Sarangadharan
@DarrenEastman I've opened an MR to try to improve the documentation around the enforcement of runner plan limits
requested review from @DarrenEastman
- Resolved by Pedro Pombeiro
@pedropombeiro
- please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request.
- Resolved by Pedro Pombeiro
- Resolved by Pedro Pombeiro
- Resolved by Roshni Sarangadharan
Thanks, @pedropombeiro. Please check the technical accuracy of my suggestions.
added maintenancerefactor label
added typemaintenance label
added 135 commits
-
30e33f56...1cac9fdd - 133 commits from branch
master
- 80882980 - Clarify runner plan limits
- 926253fa - Apply MR suggestions
-
30e33f56...1cac9fdd - 133 commits from branch
requested review from @rsarangadharan
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
- A deleted user
added backend label
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for b65938f0expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Verify | 1 | 0 | 0 | 0 | 1 | ✅ | | Create | 1 | 0 | 0 | 0 | 1 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 2 | 0 | 0 | 0 | 2 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for b65938f0expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 140 | 0 | 19 | 0 | 159 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Verify | 50 | 0 | 15 | 0 | 65 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Govern | 84 | 0 | 10 | 0 | 94 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Secure | 2 | 0 | 5 | 0 | 7 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 437 | 0 | 118 | 0 | 555 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
- Resolved by Roshni Sarangadharan
@rsarangadharan seems like there were a couple of places that were missing, could you please review the most recent commit? Please note that this also changes the UI text in the settings (I'll add screenshots to the MR description).
Edited by Pedro Pombeiro
added UI text label
requested review from @rsarangadharan and removed approval
Hey @mrincon
, mind doing the maintainer review?requested review from @mrincon
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
started a merge train
mentioned in commit 6aa3df52
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label