Remove checks which are done in Feature Authorizer anyway
What does this MR do and why?
With change in FeatureAuthorizer we do not additional checks if user is allowed to use AI feature. This MR simply removes duplicated code.
References
Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Related to #507464 (closed)
Merge request reports
Activity
changed milestone to %17.8
added Stretch devopsai-powered groupai framework sectiondata-science typebug workflowin dev + 1 deleted label
assigned to @mksionek
- A deleted user
added backend label
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @tvellishetty
(UTC+5.5, 4.5 hours ahead of author)
@alejandro
(UTC-5, 6 hours behind author)
groupauthorization Reviewer review is optional for groupauthorization @jarka
(UTC+1, same timezone as author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded pipelinetier-1 label
- Resolved by Gosia Ksionek
@micthomas can you please review?
requested review from @micthomas
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
requested review from @stanhu and removed review request for @micthomas
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for f7f3ef40expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 57 | 0 | 2 | 0 | 59 | ✅ | | Verify | 46 | 0 | 3 | 0 | 49 | ✅ | | Create | 107 | 0 | 3 | 0 | 110 | ✅ | | Plan | 53 | 0 | 0 | 0 | 53 | ✅ | | Data Stores | 21 | 0 | 0 | 0 | 21 | ✅ | | Package | 25 | 0 | 0 | 0 | 25 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Analytics | 1 | 0 | 0 | 0 | 1 | ✅ | | Release | 3 | 0 | 0 | 0 | 3 | ✅ | | Monitor | 3 | 0 | 0 | 0 | 3 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 321 | 0 | 8 | 0 | 329 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for f7f3ef40expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 51 | 0 | 15 | 0 | 66 | ✅ | | Create | 140 | 0 | 19 | 1 | 159 | ✅ | | Package | 30 | 0 | 14 | 0 | 44 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Govern | 84 | 0 | 10 | 0 | 94 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Secure | 2 | 0 | 5 | 0 | 7 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 444 | 0 | 118 | 1 | 562 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
aborted automatic add to merge train because the source branch was updated. Learn more.
reset approvals from @stanhu by pushing to the branch
@jarka I need review due to the small changes in policies. Would you have time to take a look?
requested review from @jarka
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
Thanks @mksionek , I just got back from PTO, MWPS set
added this merge request to the merge train at position 2
mentioned in commit 25e8b596
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowproduction label and removed workflowcanary label
added workflowstaging label and removed workflowproduction label
added workflowpost-deploy-db-staging label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in issue gitlab-com/www-gitlab-com#35030
added technical debt label and removed 1 deleted label