Remove todos_vue_application feature flag and purge all code

changed milestone to %17.9

added Category:Notifications devopsfoundations grouppersonal productivity maintenanceremoval sectioncore platform typemaintenance labels

assigned to @thutterer

added pipelinetier-1 label

added backend frontend labels

	2 Warnings
	This merge request is quite big (917 lines changed), please consider splitting it into multiple merge requests.
	This merge request contains lines with testid selectors. Please ensure `e2e:test-on-omnibus` job is run.

`testid` selectors

The following changed lines in this MR contain testid selectors:

`app/views/dashboard/todos/index.html.haml`

-              = dropdown_tag(group_dropdown_label(params[:group_id], _("Group")), options: { toggle_class: 'js-group-search js-filter-submit gl-w-full sm:gl-w-auto', title: s_("Todos|Filter by group"), filter: true, filterInput: 'input#group-search', dropdown_class: 'dropdown-menu-selectable dropdown-menu-group js-filter-submit', placeholder: _("Search groups"), data: { default_label: _("Group"), display: 'static', testid: 'group-dropdown' } })
-    .js-todos-list-container{ data: { testid: "todos-list-container" } }

If the e2e:test-on-omnibus job in the qa stage has run automatically, please ensure the tests are passing. If the job has not run, please start the manual:e2e-test-pipeline-generate job in the prepare stage and ensure the tests in follow-up:e2e:test-on-omnibus-ee pipeline are passing.

For the list of known failures please refer to the latest pipeline triage issue.

If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.

Reviewer roulette

Category	Reviewer	Maintainer
backend	`@zmartins` (UTC+1, same timezone as author)	`@eurie` (UTC-5, 6 hours behind author)
frontend	`@ccharnolevsky` (UTC+2, 1 hour ahead of author)	`@slashmanov` (UTC+4, 3 hours ahead of author)
test for `spec/features/*`	`@zmartins` (UTC+1, same timezone as author)	Maintainer review is optional for test for `spec/features/*`

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

mentioned in issue #503821 (closed)

added 3499 commits

8b2ccd94...94f09f31 - 3498 commits from branch master
2c904cf8 - Enable new implementation of To-Do dashboard

Compare with previous version

added QA label

	5 Warnings
	This merge request is quite big (1707 lines changed), please consider splitting it into multiple merge requests.
	b703a693: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	b78f4395: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	The master pipeline status page reported failures in rspec-ee unit pg14 single-redis 2/39 rspec integration pg14 single-redis 16/20 If these jobs fail in your merge request with the same errors, then they are not caused by your changes. Please check for any on-going incidents in the incident issue tracker or in the `#master-broken` Slack channel.
	This merge request contains lines with testid selectors. Please ensure `e2e:test-on-omnibus` job is run.

`testid` selectors

The following changed lines in this MR contain testid selectors:

`app/views/dashboard/todos/index.html.haml`

-              = dropdown_tag(group_dropdown_label(params[:group_id], _("Group")), options: { toggle_class: 'js-group-search js-filter-submit gl-w-full sm:gl-w-auto', title: s_("Todos|Filter by group"), filter: true, filterInput: 'input#group-search', dropdown_class: 'dropdown-menu-selectable dropdown-menu-group js-filter-submit', placeholder: _("Search groups"), data: { default_label: _("Group"), display: 'static', testid: 'group-dropdown' } })
-    .js-todos-list-container{ data: { testid: "todos-list-container" } }

If the e2e:test-on-omnibus job in the qa stage has run automatically, please ensure the tests are passing. If the job has not run, please start the manual:e2e-test-pipeline-generate job in the prepare stage and ensure the tests in follow-up:e2e:test-on-omnibus-ee pipeline are passing.

For the list of known failures please refer to the latest pipeline triage issue.

If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.

Reviewer roulette

Category	Reviewer	Maintainer
backend	`@stefanosxan` (UTC+1, same timezone as author)	`@sgarg_gitlab` (UTC+5.5, 4.5 hours ahead of author)
frontend	`@smaglangit` (UTC+8, 7 hours ahead of author)	`@jivanvl` (UTC-6, 7 hours behind author)
QA	`@hmuralidhar` (UTC+11, 10 hours ahead of author)	Maintainer review is optional for QA
test for `spec/features/*`	`@stefanosxan` (UTC+1, same timezone as author)	Maintainer review is optional for test for `spec/features/*`

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for 84b415ca

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Create      | 138    | 0      | 20      | 0     | 158   | ✅     |
| Govern      | 80     | 0      | 12      | 0     | 92    | ✅     |
| Verify      | 50     | 0      | 20      | 0     | 70    | ✅     |
| Plan        | 82     | 0      | 8       | 0     | 90    | ✅     |
| Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
| Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
| Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
| Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
| Package     | 25     | 0      | 13      | 0     | 38    | ✅     |
| Manage      | 0      | 0      | 10      | 0     | 10    | ➖     |
| Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
| Secure      | 4      | 0      | 3       | 0     | 7     | ✅     |
| Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
| Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
| ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 429    | 0      | 124     | 0     | 553   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-test-on-cng: test report for 84b415ca

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Create      | 139    | 0      | 19      | 0     | 158   | ✅     |
| Package     | 30     | 0      | 14      | 0     | 44    | ✅     |
| Verify      | 51     | 0      | 19      | 0     | 70    | ✅     |
| Manage      | 0      | 0      | 10      | 0     | 10    | ➖     |
| Plan        | 82     | 0      | 8       | 0     | 90    | ✅     |
| Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
| Govern      | 82     | 0      | 10      | 0     | 92    | ✅     |
| Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
| Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
| Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
| Secure      | 2      | 0      | 5       | 0     | 7     | ✅     |
| Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
| ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
| Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 436    | 0      | 123     | 0     | 559   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

added 8 commits

531c88e2 - Enable new Vue implementation of To-Do dashboard for everyone
16c90334 - Remove unused todo_target_name helper method
3208145b - Remove unused todo_target_aria_label helper method
9b207ac5 - Remove unused todo_author_display? helper method
578a0ab3 - Remove unused todo_action_name helper method
d0d917a7 - Remove unused todo_self_addressing helper method
1785afae - Remove unused todo_due_date helper method
85aaff8e - Remove unused todos_has_filtered_results? helper method

Compare with previous version

added 13 commits

85aaff8e...3f340cf3 - 3 earlier commits
e7347e35 - Remove unused todo_author_display? helper method
5429d124 - Remove unused todo_action_name helper method
cab1a69e - Remove unused todo_self_addressing helper method
e4bb3aac - Remove unused todo_due_date helper method
e0ea2d9c - Remove unused todos_has_filtered_results? helper method
efb4935c - Remove unused todo_target_state_pill helper method
a71e576e - Remove unused todo_target_title helper method
6b897008 - Update feature spec
fa055986 - Switch old feature specs to test new implementation
3731798f - Switch filtering feature specs to test new implementation

Compare with previous version

marked this merge request as ready

changed title from Draft: Enable new implementation of To-Do dashboard to Remove todos_vue_application feature flag and purge all code

changed the description

@squadri Hi You are the lucky winner Your prize: a 2k LOC MR

But no worries, this is 99% deleting old code, which is always fun.

I tried to keep the commits in a way that makes it somewhat easy to review this, but please let me know if you need more info

Please review backend and test if possible. Thanks!

requested review from @squadri

removed review request for @squadri

mentioned in merge request !178013 (merged)

added 507 commits

3731798f...a6ca72f6 - 493 commits from branch master
a6ca72f6...8ae70d40 - 4 earlier commits
ed98002c - Remove unused todo_target_name helper method
3fdc7724 - Remove unused todo_target_aria_label helper method
b78f4395 - Remove unused todo_author_display? helper method
b703a693 - Remove unused todo_action_name helper method
5b0f95b6 - Remove unused todo_self_addressing helper method
f3800bf3 - Remove unused todo_due_date helper method
233aafc5 - Remove unused todos_has_filtered_results? helper method
93b2a189 - Remove unused todo_target_state_pill helper method
d48c5bf4 - Remove unused todo_target_title helper method
c2898fcc - Remove unused CSS page bundle

Compare with previous version

changed target branch from master to 509080-migrate-remaining-feature-specs

changed the description

@pgascouvaillancourt May I volunteer you to do the frontend review on this rather big MR

No rush, the MR has a dependency on !178013 (merged) being merged first.

Thaaanks!

requested review from @pgascouvaillancourt

requested review from @squadri

approved this merge request

added pipeline:mr-approved label

added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label

Before you set this MR to auto-merge

This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

Before you set this MR to auto-merge, please check the following:

You are the last maintainer of this merge request
The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
This pipeline is recent enough (created in the last 8 hours)

If all the criteria above apply, please set auto-merge for this merge request.

See pipeline tiers and merging a merge request for more details.

requested review from @eurie

requested review from @GitLabDuo

I have reviewed the merge request and left a mix of questions and recommendations. The review covers a wide range of topics including feature flag usage, method removals, route changes, and test coverage. I estimate there is a significant amount of work required to address the concerns raised, particularly regarding potential functionality breakages and ensuring proper test coverage.

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits fd4187b6 and 84b415ca

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	4.43 MB	4.43 MB	-	-0.0 %
mainChunk	3.28 MB	3.28 MB	-	0.0 %

Significant Reduction: 1

Expand

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
pages.dashboard.todos.index	755.57 KB	643.35 KB	-112.22 KB	-14.9 %

Note: We do not have exact data for fd4187b6. So we have used data from: a3d72b08.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.

Please look at the full report for more details

Remove todos_vue_application feature flag and purge all code

What does this MR do and why?

MR acceptance checklist

Screenshots or screen recordings

How to set up and validate locally

Activity

`testid` selectors

`app/views/dashboard/todos/index.html.haml`

Reviewer roulette

`testid` selectors

`app/views/dashboard/todos/index.html.haml`

Reviewer roulette

E2E Test Result Summary

Before you set this MR to auto-merge

Bundle size analysis [beta]

Special assets

Significant Reduction: 1

Remove todos_vue_application feature flag and purge all code

What does this MR do and why?

MR acceptance checklist

Screenshots or screen recordings

How to set up and validate locally

Merge request reports

Activity

testid selectors

app/views/dashboard/todos/index.html.haml

Reviewer roulette

testid selectors

app/views/dashboard/todos/index.html.haml

Reviewer roulette

E2E Test Result Summary

Before you set this MR to auto-merge

Bundle size analysis [beta]

Special assets

Significant Reduction: 1

`testid` selectors

`app/views/dashboard/todos/index.html.haml`

`testid` selectors

`app/views/dashboard/todos/index.html.haml`