Vue todo filter background use design tokens
What does this MR do and why?
Update the filter background to use the background.color.subtle
design token.
I am using a script to turn all colors not using a design token to hotpink
and this is the most annoying one...
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
No visual change |
![]() |
No visual change |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Enable
todos_vue_application
feature flag (http://127.0.0.1:3000/rails/features/) - http://127.0.0.1:3000/dashboard/todos
Merge request reports
Activity
changed milestone to %17.7
assigned to @danmh
added grouppersonal productivity label
added devopsfoundations sectioncore platform labels
added frontend label and removed devopsfoundations sectioncore platform labels
added devopsfoundations sectioncore platform labels
added UI polish label and removed devopsfoundations sectioncore platform labels
added devopsfoundations sectioncore platform labels
added pipelinetier-1 label
added foundationdesign tokens label and removed devopsfoundations pipelinetier-1 sectioncore platform labels
added devopsfoundations sectioncore platform labels
added pipelinetier-1 label
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, maintenanceperformance, documentation, QA labels.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer frontend @mcavoj
(UTC+1, 1 hour ahead of author)
@ntepluhina
(UTC+1, 1 hour ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerrequested review from @leipert
- Resolved by Lukas Eipert
@leipert would you mind taking a look at this small migration?
cc: @ameliabauerly
- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@danmh
- please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 08c540a8 and af6bd764
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.49 MB 4.49 MB - 0.0 % mainChunk 3.37 MB 3.37 MB - 0.0 %
Note: We do not have exact data for 08c540a8. So we have used data from: bd394d73.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded typemaintenance label
added pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
Such subtle, much wow. Thanks, @danmh!
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for af6bd764expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 43 | 0 | 2 | 0 | 45 | ✅ | | Create | 129 | 0 | 22 | 0 | 151 | ✅ | | Govern | 75 | 0 | 3 | 0 | 78 | ✅ | | Plan | 76 | 0 | 0 | 0 | 76 | ✅ | | Package | 25 | 0 | 11 | 0 | 36 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Ai-powered | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 403 | 0 | 41 | 0 | 444 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for af6bd764expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Create | 140 | 0 | 20 | 0 | 160 | ✅ | | Govern | 84 | 0 | 9 | 1 | 93 | ✅ | | Verify | 49 | 0 | 16 | 0 | 65 | ✅ | | Secure | 2 | 0 | 5 | 0 | 7 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Fulfillment | 2 | 0 | 7 | 1 | 9 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Analytics | 2 | 0 | 0 | 1 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 436 | 0 | 119 | 3 | 555 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
started a merge train
mentioned in commit 5331f535
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label