Organize EE admin runner feature test suite by role
What does this MR do and why?
This change uses the "ROLE_ACTION_spec.rb" format in the file names of the admin runner feature tests for EE features.
References
- https://docs.gitlab.com/ee/development/testing_guide/best_practices.html#system--feature-tests
- Review feature specs for runners (#366796 - closed)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #366796 (closed)
Merge request reports
Activity
changed milestone to %17.7
assigned to @mrincon
mentioned in issue #366796 (closed)
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels
Reviewer roulette
Category Reviewer Maintainer test for spec/features/*
@emmaspark
(UTC+1, same timezone as author)
Maintainer review is optional for test for spec/features/*
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger Generated bygitlab_quality-test_tooling
.
Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.Click to expand
Job File Name Duration Expected duration #8517287474 ee/spec/features/admin/runners/admin_manages_runner_cost_factor_spec.rb#L56
Admin manages runner cost factor cost factor when Gitlab.com? when editing an instance runner behaves like shows populated cost factor shows cost factor fields 77.96 s < 50.13 s - A deleted user
added rspec:slow test detected label
- Resolved by Miguel Rincon
@splattael care to review this refactor? Thanks!
requested review from @splattael
requested review from @emmaspark
added pipeline:mr-approved label
added backend label
started a merge train
mentioned in commit dfd1928b
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label