feat: Update the treatment of Health Status in the work item list
-
Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you can request access to GitLab Duo. -
Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you can request access to GitLab Duo.
What does this MR do and why?
![]() |
![]() |
---|---|
After | Before |
![]() |
![]() |
---|---|
After | Before |
![]() |
![]() |
---|---|
After | Before |
Fixes #503412 (closed)
Merge request reports
Activity
mentioned in merge request !172931 (closed)
added pipelinetier-1 label
Thanks for your contribution to GitLab @vedant-jain03!
Did you know about our community forks? Working from there will make your contribution process easier. Please check it out!
- If you need help, page a coach by clicking here or come say hi on Discord.
- When you're ready, request a review by clicking here.
- We welcome AI-generated contributions and offer complimentary access to GitLab Duo! Check out the top of the merge request description to learn more about using AI while contributing.
- To add labels to your merge request, comment
@gitlab-bot label ~"label1" ~"label2"
.
This message was generated automatically. Improve it or delete it.
added Community contribution workflowin dev labels
assigned to @vedant-jain03
added linked-issue label
mentioned in issue gitlab-org/quality/triage-reports#21077 (closed)
requested review from @ntepluhina and @nickbrandt
- Resolved by Natalia Tepluhina
@vedant-jain03 it looks like the changes for this MR are the same as for a previous one, so I'll go ahead and approve the frontend part
@nickbrandt would you mind checking UX here?
added pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
mentioned in issue gitlab-org/quality/triage-reports#21138 (closed)
mentioned in issue gitlab-org/quality/triage-reports#21139 (closed)
added 1 commit
- cdcb0011 - style: Show no border if update timestamp is not rendered
reset approvals from @ntepluhina by pushing to the branch
added groupproduct planning typefeature labels
added devopsplan sectiondev labels
requested review from @ntepluhina
added 1 commit
- 70026fb4 - chore: Show no border if update timestamp is not rendered
- A deleted user
added frontend label
5 Warnings b36330a6: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. 4656de2a: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. This merge request does not refer to an existing milestone. This merge request contains lines with testid selectors. Please ensure e2e:test-on-omnibus
job is run.This merge request changed undocumented Vue components in
vue_shared/
. Please consider creating Stories for these components:app/assets/javascripts/vue_shared/issuable/list/components/issuable_item.vue
app/assets/javascripts/vue_shared/issuable/list/components/issuable_list_root.vue
2 Messages This merge request includes changes to Vue files that have both CE and EE versions. CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Vue
<template>
in CE and EESome Vue files in CE have a counterpart in EE. (For example,
path/to/file.vue
andee/path/to/file.vue
.)When run in the context of CE, the
<template>
of the CE Vue file is used. When run in the context of EE, the<template>
of the EE Vue file is used.It's easy to accidentally make a change to a CE
<template>
that should appear in both CE and EE without making the change in both places. When this happens, the change only takes effect in CE.The following Vue files were changed as part of this merge request that include both a CE and EE version of the file:
app/assets/javascripts/work_items/components/work_item_health_status.vue
app/assets/javascripts/issues/list/components/issue_card_time_info.vue
app/assets/javascripts/work_items/pages/work_items_list_app.vue
ee/app/assets/javascripts/issues/list/components/issue_card_time_info.vue
If you made a change to the
<template>
of any of these Vue files that should be visible in both CE and EE, please ensure you have made your change to both versions of the file.A better alternative
An even better alternative is to refactor this component to only use a single template for both CE and EE. More info on this approach here: https://docs.gitlab.com/ee/development/ee_features.html#template-tag
testid
selectorsThe following changed lines in this MR contain
testid
selectors:app/assets/javascripts/vue_shared/issuable/list/components/issuable_item.vue
- data-testid="issuable-timestamp" + data-testid="issuable-timestamp"
If the
e2e:test-on-omnibus
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:test-on-omnibus-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer frontend @bsandlin
(UTC-6)
@mgandres
(UTC+8)
UX @nickbrandt
(UTC-7)
Maintainer review is optional for UX Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 12744163 and b36330a6
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.41 MB 4.41 MB - 0.0 % mainChunk 3.28 MB 3.28 MB - 0.0 %
Note: We do not have exact data for 12744163. So we have used data from: 1cac9fdd.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerE2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for b36330a6expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 82 | 0 | 8 | 0 | 90 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Create | 135 | 0 | 20 | 0 | 155 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Verify | 48 | 0 | 17 | 0 | 65 | ✅ | | Govern | 80 | 0 | 12 | 0 | 92 | ✅ | | Package | 25 | 0 | 13 | 0 | 38 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Secure | 4 | 0 | 3 | 0 | 7 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 425 | 0 | 120 | 0 | 545 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for b36330a6expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Create | 140 | 0 | 19 | 1 | 159 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Govern | 84 | 0 | 10 | 0 | 94 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Verify | 49 | 0 | 16 | 0 | 65 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Package | 30 | 0 | 14 | 0 | 44 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Secure | 2 | 0 | 5 | 0 | 7 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 442 | 0 | 119 | 1 | 561 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
- Resolved by Natalia Tepluhina
Thanks @ntepluhina for approving, would you mind helping me with the failing job?
added 958 commits
-
70026fb4...a225ab20 - 956 commits from branch
gitlab-org:master
- f4af9947 - feat: Update the treatment of Health Status in the work item list
- 440af070 - chore: Show no border if update timestamp is not rendered
-
70026fb4...a225ab20 - 956 commits from branch
added UX label
Thanks for helping us improve the UX of GitLab. Your contribution is appreciated! We have pinged our UX team, so stay tuned for their feedback.
This message was generated automatically. Improve it or delete it.
- Resolved by Natalia Tepluhina
Thanks @ntepluhina for enabling the auto merge but it seems like the pipeline still fails
reset approvals from @ntepluhina by pushing to the branch
- Resolved by Natalia Tepluhina
requested review from @ntepluhina
- Resolved by Natalia Tepluhina
@vedant-jain03 it looks like we have issues with the test too. Would you mind applying this patch to your branch?
diff --git a/spec/frontend/work_items/components/work_item_health_status_spec.js b/spec/frontend/work_items/components/work_item_health_status_spec.js index 31bc5d46a96a..9b443f0ec879 100644 --- a/spec/frontend/work_items/components/work_item_health_status_spec.js +++ b/spec/frontend/work_items/components/work_item_health_status_spec.js @@ -1,8 +1,9 @@ import { shallowMount } from '@vue/test-utils'; -import IssueHealthStatus from 'ee/related_items_tree/components/issue_health_status.vue'; import WorkItemHealthStatus from '~/work_items/components/work_item_health_status.vue'; import { WIDGET_TYPE_HEALTH_STATUS } from '~/work_items/constants'; +const IssueHealthStatus = { template: '<div></div>', props: ['healthStatus'] }; + describe('WorkItemHealthStatus', () => { let wrapper;
added 1663 commits
-
fac80d49...5e47cb72 - 1660 commits from branch
gitlab-org:master
- 4656de2a - feat: Update the treatment of Health Status in the work item list
- d72c6474 - chore: Show no border if update timestamp is not rendered
- 1ccc90e6 - chore: better import syntax
Toggle commit list-
fac80d49...5e47cb72 - 1660 commits from branch
started a merge train
mentioned in commit 3b067bef
@vedant-jain03, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- React with a
or a on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Request access to our community forks to receive complimentary access to GitLab Duo, our AI-powered features. With Code Suggestions, Chat, Root Cause Analysis and more AI-powered features, GitLab Duo helps to boost your efficiency and effectiveness by reducing the time required to write and understand code and pipelines. Visit the GitLab Duo documentation to learn more about the benefits.
Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.
Thanks for your help!
This message was generated automatically. Improve it or delete it.
- React with a
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
changed milestone to %17.8
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in issue #503412 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label