Skip to content
Snippets Groups Projects

feat: Update the treatment of Health Status in the work item list

Merged Vedant Jain requested to merge vedant-jain03/gitlab:issue#503412 into master
All threads resolved!
  • Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you can request access to GitLab Duo.

  • Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you can request access to GitLab Duo.

What does this MR do and why?

Screenshot_2024-11-17_at_10.35.02_PM Screenshot_2024-11-17_at_10.38.13_PM
After Before
Screenshot_2024-11-17_at_10.36.00_PM Screenshot_2024-11-17_at_10.39.09_PM
After Before
Screenshot_2024-11-17_at_10.36.36_PM Screenshot_2024-11-17_at_10.40.11_PM
After Before

Fixes #503412 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Vedant Jain added 1 commit

    added 1 commit

    Compare with previous version

  • Vedant Jain requested review from @ntepluhina

    requested review from @ntepluhina

    • Resolved by Natalia Tepluhina

      @vedant-jain03 it looks like we have issues with the test too. Would you mind applying this patch to your branch?

      diff --git a/spec/frontend/work_items/components/work_item_health_status_spec.js b/spec/frontend/work_items/components/work_item_health_status_spec.js
      index 31bc5d46a96a..9b443f0ec879 100644
      --- a/spec/frontend/work_items/components/work_item_health_status_spec.js
      +++ b/spec/frontend/work_items/components/work_item_health_status_spec.js
      @@ -1,8 +1,9 @@
       import { shallowMount } from '@vue/test-utils';
      -import IssueHealthStatus from 'ee/related_items_tree/components/issue_health_status.vue';
       import WorkItemHealthStatus from '~/work_items/components/work_item_health_status.vue';
       import { WIDGET_TYPE_HEALTH_STATUS } from '~/work_items/constants';
       
      +const IssueHealthStatus = { template: '<div></div>', props: ['healthStatus'] };
      +
       describe('WorkItemHealthStatus', () => {
         let wrapper;
  • Vedant Jain added 1663 commits

    added 1663 commits

    • fac80d49...5e47cb72 - 1660 commits from branch gitlab-org:master
    • 4656de2a - feat: Update the treatment of Health Status in the work item list
    • d72c6474 - chore: Show no border if update timestamp is not rendered
    • 1ccc90e6 - chore: better import syntax

    Compare with previous version

  • Vedant Jain added 1 commit

    added 1 commit

    Compare with previous version

  • Natalia Tepluhina approved this merge request

    approved this merge request

  • Natalia Tepluhina resolved all threads

    resolved all threads

  • Natalia Tepluhina enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • mentioned in commit 3b067bef

  • @vedant-jain03, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:

    1. React with a :thumbsup: or a :thumbsdown: on this comment to describe your experience.
    2. Create a new comment starting with @gitlab-bot feedback below, and leave any additional feedback you have for us in the comment.

    Request access to our community forks to receive complimentary access to GitLab Duo, our AI-powered features. With Code Suggestions, Chat, Root Cause Analysis and more AI-powered features, GitLab Duo helps to boost your efficiency and effectiveness by reducing the time required to write and understand code and pipelines. Visit the GitLab Duo documentation to learn more about the benefits.

    Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.

    Thanks for your help! :heart:

    This message was generated automatically. Improve it or delete it.

  • added workflowstaging label and removed workflowcanary label

  • changed milestone to %17.8

  • mentioned in issue #503412 (closed)

  • Please register or sign in to reply
    Loading