Skip to content
Snippets Groups Projects

Add possibility to delete requirements

Merged Nataliia Radina requested to merge 506637-requirement-deleting into master
All threads resolved!

What does this MR do and why?

Adds possibility to delete requirements

References

Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

New framework Existing
Screen_Recording_2024-11-29_at_12.28.47 Screen_Recording_2024-11-29_at_12.19.32

How to set up and validate locally

  1. Make sure you have admin rights and group with an Ultimate subscription
  2. Go to Compliance Center frameworks report
  3. Enable FF echo "Feature.enable(:enable_standards_adherence_dashboard_v2)" | gdk rails c
  4. Try deleting requirements while editing/creating framework

Related to #506637 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Grace Lin
  • Grace Lin
  • Grace Lin
  • Grace Lin
    • Resolved by Nataliia Radina

      Hi @nradina, thank you for the feature! The MR looks good, I just have a few comments and two UX suggestions here. Back to you for now :ping_pong:

      1. For the toast that appears after the user deletes a requirement, because it has an action (Undo), I would suggest keeping it visible rather than letting it disappear automatically. The Pajamas page on toasts lists when it can be dismissed:

      A toast with an action is only dismissed when a user does one of the following:

      • Clicks the action.
      • Clicks the dismiss button.
      • Navigates to another page.
      1. If the user clicks the Undo in the toast, the requirement is restored. I would suggest two things after that:
        1. Hiding the toast since it's no longer applicable (this would be addressed by the previous point).
        2. Showing another toast indicating that the requirement was restored.
  • added 1 commit

    Compare with previous version

  • Nataliia Radina
  • Nataliia Radina requested review from @glin5

    requested review from @glin5

  • Grace Lin approved this merge request

    approved this merge request

  • added pipelinetier-2 label and removed pipelinetier-1 label

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for e52ddb98

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Govern      | 75     | 0      | 3       | 0     | 78    | ✅     |
    | Verify      | 43     | 0      | 2       | 0     | 45    | ✅     |
    | Plan        | 76     | 0      | 0       | 0     | 76    | ✅     |
    | Data Stores | 33     | 0      | 1       | 0     | 34    | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Create      | 129    | 0      | 22      | 0     | 151   | ✅     |
    | Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Package     | 25     | 0      | 11      | 0     | 36    | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Manage      | 1      | 0      | 1       | 0     | 2     | ✅     |
    | Ai-powered  | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Secure      | 4      | 0      | 0       | 0     | 4     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 403    | 0      | 41      | 0     | 444   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-cng: :white_check_mark: test report for e52ddb98

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Create      | 140    | 0      | 20      | 0     | 160   | ✅     |
    | Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
    | Verify      | 49     | 0      | 16      | 0     | 65    | ✅     |
    | Fulfillment | 2      | 0      | 7       | 1     | 9     | ✅     |
    | Package     | 24     | 0      | 14      | 0     | 38    | ✅     |
    | Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
    | Plan        | 86     | 0      | 8       | 0     | 94    | ✅     |
    | Govern      | 84     | 0      | 9       | 1     | 93    | ✅     |
    | Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
    | Secure      | 2      | 0      | 5       | 0     | 7     | ✅     |
    | Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
    | Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
    | Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Analytics   | 2      | 0      | 0       | 1     | 2     | ✅     |
    | ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 436    | 0      | 119     | 3     | 555   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • Nataliia Radina requested review from @janis

    requested review from @janis

  • Janis Altherr
  • Janis Altherr approved this merge request

    approved this merge request

  • Janis Altherr enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Janis Altherr resolved all threads

    resolved all threads

  • Janis Altherr mentioned in commit 0ecf3c10

    mentioned in commit 0ecf3c10

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading