Add possibility to delete requirements
What does this MR do and why?
Adds possibility to delete requirements
References
Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
New framework | Existing |
---|---|
Screen_Recording_2024-11-29_at_12.28.47 | Screen_Recording_2024-11-29_at_12.19.32 |
How to set up and validate locally
- Make sure you have admin rights and group with an Ultimate subscription
- Go to Compliance Center frameworks report
- Enable FF
echo "Feature.enable(:enable_standards_adherence_dashboard_v2)" | gdk rails c
- Try deleting requirements while editing/creating framework
Related to #506637 (closed)
Merge request reports
Activity
changed milestone to %17.7
assigned to @nradina
added pipelinetier-1 label
3 Warnings e52ddb98: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. fe6fe802: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. This merge request contains lines with testid selectors. Please ensure e2e:test-on-omnibus
job is run.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
testid
selectorsThe following changed lines in this MR contain
testid
selectors:ee/app/assets/javascripts/compliance_dashboard/components/frameworks_report/edit_framework/components/requirements_section.vue
+ <gl-disclosure-dropdown-item data-testid="delete-action" @action="$emit('delete', index)">
If the
e2e:test-on-omnibus
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:test-on-omnibus-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer frontend @julie_huang
(UTC+11, 10 hours ahead of author)
@tbulva
(UTC+1, same timezone as author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits fa1100ce and e52ddb98
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.49 MB 4.49 MB - 0.0 % mainChunk 3.37 MB 3.37 MB - 0.0 %
Note: We do not have exact data for fa1100ce. So we have used data from: 106cd7d2.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangerremoved UX label
@glin5 could you please review?
requested review from @glin5
- Resolved by Nataliia Radina
- Resolved by Grace Lin
- Resolved by Grace Lin
- Resolved by Grace Lin
- Resolved by Grace Lin
- Resolved by Nataliia Radina
Hi @nradina, thank you for the feature! The MR looks good, I just have a few comments and two UX suggestions here. Back to you for now
- For the toast that appears after the user deletes a requirement, because it has an action (
Undo
), I would suggest keeping it visible rather than letting it disappear automatically. The Pajamas page on toasts lists when it can be dismissed:
A toast with an action is only dismissed when a user does one of the following:
- Clicks the action.
- Clicks the dismiss button.
- Navigates to another page.
- If the user clicks the
Undo
in the toast, the requirement is restored. I would suggest two things after that:- Hiding the toast since it's no longer applicable (this would be addressed by the previous point).
- Showing another toast indicating that the requirement was restored.
- For the toast that appears after the user deletes a requirement, because it has an action (
- Resolved by Janis Altherr
requested review from @glin5
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for e52ddb98expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 75 | 0 | 3 | 0 | 78 | ✅ | | Verify | 43 | 0 | 2 | 0 | 45 | ✅ | | Plan | 76 | 0 | 0 | 0 | 76 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Create | 129 | 0 | 22 | 0 | 151 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Package | 25 | 0 | 11 | 0 | 36 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Ai-powered | 0 | 0 | 1 | 0 | 1 | ➖ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 403 | 0 | 41 | 0 | 444 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for e52ddb98expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 140 | 0 | 20 | 0 | 160 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Verify | 49 | 0 | 16 | 0 | 65 | ✅ | | Fulfillment | 2 | 0 | 7 | 1 | 9 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Govern | 84 | 0 | 9 | 1 | 93 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Secure | 2 | 0 | 5 | 0 | 7 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Analytics | 2 | 0 | 0 | 1 | 2 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 436 | 0 | 119 | 3 | 555 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
requested review from @janis
- Resolved by Nataliia Radina
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
started a merge train
mentioned in commit 0ecf3c10
mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#9537 (closed)
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label